Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 923803003: Fix up a few more lint warnings in chrome/ (Closed)

Created:
5 years, 10 months ago by aurimas (slooooooooow)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, mkwst+watchlist-passwords_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix up a few more lint warnings in chrome/ BUG=266140 TBR=jbudorick@chromium.org Committed: https://crrev.com/44c6947c069fbcbd5ce0be0da3a2920684ffebd3 Cr-Commit-Position: refs/heads/master@{#318094}

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : newt's nits #

Total comments: 1

Patch Set 5 : Undo changes in autofill_profile_editor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M build/android/lint/suppressions.xml View 1 2 chunks +25 lines, -0 lines 0 comments Download
M chrome/android/java/res/layout/autofill_card_unmask_prompt.xml View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/android/java/res/layout/password_generation_popup_suggestion.xml View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/res/layout/preference_category.xml View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/java/res/layout/website_settings_permission_row.xml View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
aurimas (slooooooooow)
PTAL
5 years, 10 months ago (2015-02-13 02:01:59 UTC) #2
aurimas (slooooooooow)
ping?
5 years, 10 months ago (2015-02-18 17:57:45 UTC) #3
newt (away)
Theresa: could you comment on autofill_credit_card_editor.xml? https://chromiumcodereview.appspot.com/923803003/diff/20001/chrome/android/java/res/layout/autofill_credit_card_editor.xml File chrome/android/java/res/layout/autofill_credit_card_editor.xml (left): https://chromiumcodereview.appspot.com/923803003/diff/20001/chrome/android/java/res/layout/autofill_credit_card_editor.xml#oldcode35 chrome/android/java/res/layout/autofill_credit_card_editor.xml:35: android:contentDescription="@string/autofill_credit_card_editor_name" IIRC, there ...
5 years, 10 months ago (2015-02-18 18:58:11 UTC) #5
aurimas (slooooooooow)
Theresa: ping?
5 years, 9 months ago (2015-02-24 02:00:15 UTC) #6
Theresa
Got lost in my inbox, sorry! https://chromiumcodereview.appspot.com/923803003/diff/20001/chrome/android/java/res/layout/autofill_credit_card_editor.xml File chrome/android/java/res/layout/autofill_credit_card_editor.xml (left): https://chromiumcodereview.appspot.com/923803003/diff/20001/chrome/android/java/res/layout/autofill_credit_card_editor.xml#oldcode35 chrome/android/java/res/layout/autofill_credit_card_editor.xml:35: android:contentDescription="@string/autofill_credit_card_editor_name" On 2015/02/18 ...
5 years, 9 months ago (2015-02-24 02:19:52 UTC) #7
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/923803003/diff/20001/chrome/android/java/res/layout/password_generation_popup_suggestion.xml File chrome/android/java/res/layout/password_generation_popup_suggestion.xml (right): https://chromiumcodereview.appspot.com/923803003/diff/20001/chrome/android/java/res/layout/password_generation_popup_suggestion.xml#newcode13 chrome/android/java/res/layout/password_generation_popup_suggestion.xml:13: <!--suppress RelativeOverlap --> On 2015/02/18 at 18:58:11, newt wrote: ...
5 years, 9 months ago (2015-02-25 01:51:17 UTC) #8
newt (away)
https://chromiumcodereview.appspot.com/923803003/diff/60001/chrome/android/java/res/layout/autofill_profile_editor.xml File chrome/android/java/res/layout/autofill_profile_editor.xml (left): https://chromiumcodereview.appspot.com/923803003/diff/60001/chrome/android/java/res/layout/autofill_profile_editor.xml#oldcode65 chrome/android/java/res/layout/autofill_profile_editor.xml:65: android:contentDescription="@string/autofill_profile_editor_phone_number" /> So are you going to keep these?
5 years, 9 months ago (2015-02-25 01:56:49 UTC) #9
aurimas (slooooooooow)
On 2015/02/25 at 01:56:49, newt wrote: > https://chromiumcodereview.appspot.com/923803003/diff/60001/chrome/android/java/res/layout/autofill_profile_editor.xml > File chrome/android/java/res/layout/autofill_profile_editor.xml (left): > > https://chromiumcodereview.appspot.com/923803003/diff/60001/chrome/android/java/res/layout/autofill_profile_editor.xml#oldcode65 ...
5 years, 9 months ago (2015-02-25 17:52:26 UTC) #10
newt (away)
lgtm, thanks!
5 years, 9 months ago (2015-02-25 18:58:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923803003/80001
5 years, 9 months ago (2015-02-25 19:03:07 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-02-25 19:59:55 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-02-25 20:01:00 UTC) #16
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/44c6947c069fbcbd5ce0be0da3a2920684ffebd3
Cr-Commit-Position: refs/heads/master@{#318094}

Powered by Google App Engine
This is Rietveld 408576698