Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1716)

Unified Diff: build/android/lint/suppressions.xml

Issue 923803003: Fix up a few more lint warnings in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Undo changes in autofill_profile_editor Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/res/layout/autofill_card_unmask_prompt.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/lint/suppressions.xml
diff --git a/build/android/lint/suppressions.xml b/build/android/lint/suppressions.xml
index d8422a74e425688894ee4d8bc0d321ec630e637e..8d9b628c72238fe0ed27cb04bbe4a5fedc5e4eb8 100644
--- a/build/android/lint/suppressions.xml
+++ b/build/android/lint/suppressions.xml
@@ -41,6 +41,20 @@ Still reading?
<issue id="HandlerLeak">
<ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDetector.java"/>
</issue>
+ <issue id="IconDensities">
+ <!-- crbug.com/457918 is tracking missing assets -->
+ <ignore path="content/public/android/java/res/drawable-xxhdpi"/>
+ <ignore path="content/public/android/java/res/drawable-xxxhdpi"/>
+ <ignore path="chrome/android/java/res/drawable-xxhdpi"/>
+ <ignore path="chrome/android/java/res/drawable-xxxhdpi"/>
+ <ignore path="ui/android/java/res/drawable-xxhdpi"/>
+ <ignore path="ui/android/java/res/drawable-xxxhdpi"/>
+ </issue>
+ <!-- It is OK for content_shell_apk and chrome_shell_apk to have missing assets. -->
+ <issue id="IconLocation">
+ <ignore path="content/shell/android/java/res/"/>
+ <ignore path="chrome/android/shell/res/"/>
+ </issue>
<issue id="MissingApplicationIcon" severity="ignore"/>
<issue id="MissingRegistered" severity="ignore"/>
<issue id="MissingVersion">
@@ -52,12 +66,23 @@ Still reading?
<issue id="OldTargetApi">
<ignore path="AndroidManifest.xml"/>
</issue>
+ <issue id="Overdraw" severity="ignore"/>
<issue id="Recycle" severity="ignore"/>
<issue id="Registered" severity="ignore"/>
+ <issue id="RtlEnabled" severity="ignore"/>
<issue id="SdCardPath">
<ignore path="content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java"/>
</issue>
<issue id="SetJavaScriptEnabled" severity="ignore"/>
+ <issue id="UnusedResources">
+ <!-- TODO(aurimas): remove suppression once crbug.com/458328 is fixed. -->
+ <ignore path="content/public/android/java/res/layout/validation_message_bubble.xml" />
+
+ <!-- These files are used by chrome_shell_apk and chrome_apk targets. -->
+ <ignore path="chrome/android/java/res/layout/accessibility_tab_switcher.xml" />
+ <ignore path="chrome/android/java/res/drawable/btn_back.xml" />
+ <ignore path="chrome/android/java/res/drawable/btn_forward.xml" />
+ </issue>
<issue id="ViewConstructor" severity="ignore"/>
<issue id="WrongCall" severity="ignore"/>
</lint>
« no previous file with comments | « no previous file | chrome/android/java/res/layout/autofill_card_unmask_prompt.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698