Issue 923723002: Revert of Fix runit.py script on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 923723002: Revert of Fix runit.py script on windows. (Closed)

Created:
5 years, 10 months ago by jam

Modified:
5 years, 10 months ago

Reviewers:
dnj, Peter Mayo, agable, David Yen, ghost stip (do not use)

CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master

Target Ref:
refs/heads/master

Project:
tools

Visibility:
Public.

Revert of Fix runit.py script on windows. (patchset #2 id:20001 of https://codereview.chromium.org/914303007/) Reason for revert: Causing telemetry failures on bots, i.e. http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/25844 Original issue's description: > Fix runit.py script on windows. > > Windows does not execute python scripts directly so it must call > the python executable > > R=agable@chromium.org, dnj@chromium.org, petermayo@chromium.org > BUG=None > TEST=local, gclient runhooks works properly under a normal shell. > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294048 TBR=agable@chromium.org,dnj@chromium.org,petermayo@chromium.org,stip@chromium.org,dyen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294051

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	scripts/tools/runit.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923723002/1

5 years, 10 months ago (2015-02-12 21:14:45 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-12 21:14:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294051