Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 923563002: Fold VTTCue::createCueRenderingTree into VTTCue::updateDisplayTree (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, philipj_slow, gasubic, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fold VTTCue::createCueRenderingTree into VTTCue::updateDisplayTree updateDisplayTree is the only caller of the former, and this split doesn't really help much at the moment. BUG=321654 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190061

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M Source/core/html/track/vtt/VTTCue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 10 months ago (2015-02-12 16:13:13 UTC) #2
philipj_slow
lgtm I'm in Bangkok tomorrow and over the weekend, so let the reviews pile up!
5 years, 10 months ago (2015-02-12 16:48:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923563002/1
5 years, 10 months ago (2015-02-12 16:48:45 UTC) #5
fs
On 2015/02/12 16:48:13, philipj_UTC7 wrote: > I'm in Bangkok tomorrow and over the weekend, Have ...
5 years, 10 months ago (2015-02-12 16:57:33 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 17:24:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190061

Powered by Google App Engine
This is Rietveld 408576698