Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: Source/core/html/track/vtt/VTTCue.cpp

Issue 923563002: Fold VTTCue::createCueRenderingTree into VTTCue::updateDisplayTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/vtt/VTTCue.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/vtt/VTTCue.cpp
diff --git a/Source/core/html/track/vtt/VTTCue.cpp b/Source/core/html/track/vtt/VTTCue.cpp
index 03339999edfbd5bf8c3e29076b99454fef831d41..1b4970969dedd71198f12e5ddf8183ec75952f04 100644
--- a/Source/core/html/track/vtt/VTTCue.cpp
+++ b/Source/core/html/track/vtt/VTTCue.cpp
@@ -490,14 +490,6 @@ PassRefPtrWillBeRawPtr<DocumentFragment> VTTCue::getCueAsHTML()
return clonedFragment.release();
}
-PassRefPtrWillBeRawPtr<DocumentFragment> VTTCue::createCueRenderingTree()
-{
- createVTTNodeTree();
- RefPtrWillBeRawPtr<DocumentFragment> clonedFragment = DocumentFragment::create(document());
- m_vttNodeTree->cloneChildNodes(clonedFragment.get());
- return clonedFragment.release();
-}
-
void VTTCue::setRegionId(const String& regionId)
{
if (m_regionId == regionId)
@@ -804,7 +796,9 @@ void VTTCue::updateDisplayTree(double movieTime)
m_cueBackgroundBox->removeChildren();
// Update the two sets containing past and future WebVTT objects.
- RefPtrWillBeRawPtr<DocumentFragment> referenceTree = createCueRenderingTree();
+ createVTTNodeTree();
+ RefPtrWillBeRawPtr<DocumentFragment> referenceTree = DocumentFragment::create(document());
+ m_vttNodeTree->cloneChildNodes(referenceTree.get());
markFutureAndPastNodes(referenceTree.get(), startTime(), movieTime);
m_cueBackgroundBox->appendChild(referenceTree, ASSERT_NO_EXCEPTION);
}
« no previous file with comments | « Source/core/html/track/vtt/VTTCue.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698