chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc - Issue 923183003: Move URL fixup to a preliminary phase that doesn't affect virtual URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc

Issue 923183003: Move URL fixup to a preliminary phase that doesn't affect virtual URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix leak in test. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_content_browser_client.cc ('K') | « chrome/browser/sync/glue/synced_session.cc ('k') | content/browser/frame_host/navigation_controller_impl.cc » ('j') | content/browser/frame_host/navigation_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc b/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc

index 5b553b080013daca90a5edecd80a3ba89cbd9199..0d6c1da3ff1b49b9ced6ea7d581a9306d82e761d 100644

--- a/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc

+++ b/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc

@@ -69,8 +69,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientSessionsSyncTest, TimestampMatchesHistory) {

ASSERT_TRUE(CheckInitialState(0));

// We want a URL that doesn't 404 and has a non-empty title.

- // about:version is simple to render, too.

- const GURL url("about:version");

+ const GURL url("data:text/html,<html><title>Test</title></html>");

ScopedWindowMap windows;

ASSERT_TRUE(OpenTabAndGetLocalWindows(0, url, windows.GetMutable()));

@@ -103,8 +102,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientSessionsSyncTest, ResponseCodeIsPreserved) {