chrome/browser/sync/glue/synced_session.cc - Issue 923183003: Move URL fixup to a preliminary phase that doesn't affect virtual URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/synced_session.cc

Issue 923183003: Move URL fixup to a preliminary phase that doesn't affect virtual URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix leak in test. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_content_browser_client.cc ('K') | « chrome/browser/sessions/session_restore_browsertest.cc ('k') | chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc » ('j') | content/browser/frame_host/navigation_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/synced_session.cc

diff --git a/chrome/browser/sync/glue/synced_session.cc b/chrome/browser/sync/glue/synced_session.cc

index 6a0f070f8b990b32790621b719178af9caa5df29..9abc736de7f2fd0c9184e24d8ca1f391b67eee2d 100644

--- a/chrome/browser/sync/glue/synced_session.cc

+++ b/chrome/browser/sync/glue/synced_session.cc

@@ -56,7 +56,7 @@ sync_pb::SessionHeader SyncedSession::ToSessionHeader() const {

}

// Note: if you modify this, make sure you modify

-// SessionModelAssociator::ShouldSyncTab to ensure the logic matches.

+// browser_sync::sessions_util::ShouldSyncTab to ensure the logic matches.

bool ShouldSyncSessionTab(const sessions::SessionTab& tab) {

if (tab.navigations.empty())

return false;