Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 923173003: Update TtsPlatformImpl to support Lollipop SDK. (Closed)

Created:
5 years, 10 months ago by dmazzoni
Modified:
5 years, 10 months ago
CC:
chromium-reviews, aurimas (slooooooooow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@lollipop_deprecation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update TtsPlatformImpl to support Lollipop SDK. BUG=405174 Committed: https://crrev.com/3a18f195c08fcf783a1afd3b62cf502e8465bed8 Cr-Commit-Position: refs/heads/master@{#318075}

Patch Set 1 #

Total comments: 2

Patch Set 2 : javadocs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -49 lines) Patch
A chrome/android/java/src/org/chromium/chrome/browser/LollipopTtsPlatformImpl.java View 1 chunk +60 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java View 1 6 chunks +94 lines, -49 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dmazzoni
5 years, 10 months ago (2015-02-13 19:55:34 UTC) #2
newt (away)
Is there another reviewer who's more familiar with this code? If not, I can review ...
5 years, 10 months ago (2015-02-13 20:05:25 UTC) #3
dmazzoni
On 2015/02/13 20:05:25, newt wrote: > Is there another reviewer who's more familiar with this ...
5 years, 10 months ago (2015-02-13 20:10:15 UTC) #5
David Trainor- moved to gerrit
lgtm https://chromiumcodereview.appspot.com/923173003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java File chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java (right): https://chromiumcodereview.appspot.com/923173003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java#newcode196 chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java:196: protected void sendEndEventOnUiThread(final String utteranceId) { Javadocs if ...
5 years, 10 months ago (2015-02-19 00:49:40 UTC) #6
dmazzoni
https://chromiumcodereview.appspot.com/923173003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java File chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java (right): https://chromiumcodereview.appspot.com/923173003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java#newcode196 chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java:196: protected void sendEndEventOnUiThread(final String utteranceId) { On 2015/02/19 00:49:40, ...
5 years, 10 months ago (2015-02-25 17:18:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923173003/20001
5 years, 10 months ago (2015-02-25 17:21:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 18:00:17 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 18:00:56 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3a18f195c08fcf783a1afd3b62cf502e8465bed8
Cr-Commit-Position: refs/heads/master@{#318075}

Powered by Google App Engine
This is Rietveld 408576698