Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5732)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java

Issue 923173003: Update TtsPlatformImpl to support Lollipop SDK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lollipop_deprecation
Patch Set: javadocs Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/LollipopTtsPlatformImpl.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java
index 5c6059f1cebe2df7efe5dcc070c2e6d3ee245636..f7c8731365df26138684bf94fd7146c482626333 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/TtsPlatformImpl.java
@@ -5,6 +5,7 @@
package org.chromium.chrome.browser;
import android.content.Context;
+import android.os.Build;
import android.speech.tts.TextToSpeech;
import android.speech.tts.UtteranceProgressListener;
@@ -61,13 +62,13 @@ class TtsPlatformImpl {
}
private long mNativeTtsPlatformImplAndroid;
- private final TextToSpeech mTextToSpeech;
+ protected final TextToSpeech mTextToSpeech;
private boolean mInitialized;
private ArrayList<TtsVoice> mVoices;
private String mCurrentLanguage;
private PendingUtterance mPendingUtterance;
- private TtsPlatformImpl(long nativeTtsPlatformImplAndroid, Context context) {
+ protected TtsPlatformImpl(long nativeTtsPlatformImplAndroid, Context context) {
mInitialized = false;
mNativeTtsPlatformImplAndroid = nativeTtsPlatformImplAndroid;
mTextToSpeech = new TextToSpeech(context, new TextToSpeech.OnInitListener() {
@@ -83,46 +84,7 @@ class TtsPlatformImpl {
}
}
});
- mTextToSpeech.setOnUtteranceProgressListener(new UtteranceProgressListener() {
- @Override
- public void onDone(final String utteranceId) {
- ThreadUtils.runOnUiThread(new Runnable() {
- @Override
- public void run() {
- if (mNativeTtsPlatformImplAndroid != 0) {
- nativeOnEndEvent(mNativeTtsPlatformImplAndroid,
- Integer.parseInt(utteranceId));
- }
- }
- });
- }
-
- @Override
- public void onError(final String utteranceId) {
- ThreadUtils.runOnUiThread(new Runnable() {
- @Override
- public void run() {
- if (mNativeTtsPlatformImplAndroid != 0) {
- nativeOnErrorEvent(mNativeTtsPlatformImplAndroid,
- Integer.parseInt(utteranceId));
- }
- }
- });
- }
-
- @Override
- public void onStart(final String utteranceId) {
- ThreadUtils.runOnUiThread(new Runnable() {
- @Override
- public void run() {
- if (mNativeTtsPlatformImplAndroid != 0) {
- nativeOnStartEvent(mNativeTtsPlatformImplAndroid,
- Integer.parseInt(utteranceId));
- }
- }
- });
- }
- });
+ addOnUtteranceProgressListener();
}
/**
@@ -135,7 +97,11 @@ class TtsPlatformImpl {
@CalledByNative
private static TtsPlatformImpl create(long nativeTtsPlatformImplAndroid,
Context context) {
- return new TtsPlatformImpl(nativeTtsPlatformImplAndroid, context);
+ if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
+ return new LollipopTtsPlatformImpl(nativeTtsPlatformImplAndroid, context);
+ } else {
+ return new TtsPlatformImpl(nativeTtsPlatformImplAndroid, context);
+ }
}
/**
@@ -213,12 +179,8 @@ class TtsPlatformImpl {
mTextToSpeech.setSpeechRate(rate);
mTextToSpeech.setPitch(pitch);
- HashMap<String, String> params = new HashMap<String, String>();
- if (volume != 1.0) {
- params.put(TextToSpeech.Engine.KEY_PARAM_VOLUME, Double.toString(volume));
- }
- params.put(TextToSpeech.Engine.KEY_PARAM_UTTERANCE_ID, Integer.toString(utteranceId));
- int result = mTextToSpeech.speak(text, TextToSpeech.QUEUE_FLUSH, params);
+
+ int result = callSpeak(text, volume, utteranceId);
return (result == TextToSpeech.SUCCESS);
}
@@ -232,6 +194,89 @@ class TtsPlatformImpl {
}
/**
+ * Post a task to the UI thread to send the TTS "end" event.
+ */
+ protected void sendEndEventOnUiThread(final String utteranceId) {
+ ThreadUtils.runOnUiThread(new Runnable() {
+ @Override
+ public void run() {
+ if (mNativeTtsPlatformImplAndroid != 0) {
+ nativeOnEndEvent(mNativeTtsPlatformImplAndroid, Integer.parseInt(utteranceId));
+ }
+ }
+ });
+ }
+
+ /**
+ * Post a task to the UI thread to send the TTS "error" event.
+ */
+ protected void sendErrorEventOnUiThread(final String utteranceId) {
+ ThreadUtils.runOnUiThread(new Runnable() {
+ @Override
+ public void run() {
+ if (mNativeTtsPlatformImplAndroid != 0) {
+ nativeOnErrorEvent(mNativeTtsPlatformImplAndroid,
+ Integer.parseInt(utteranceId));
+ }
+ }
+ });
+ }
+
+ /**
+ * Post a task to the UI thread to send the TTS "start" event.
+ */
+ protected void sendStartEventOnUiThread(final String utteranceId) {
+ ThreadUtils.runOnUiThread(new Runnable() {
+ @Override
+ public void run() {
+ if (mNativeTtsPlatformImplAndroid != 0) {
+ nativeOnStartEvent(mNativeTtsPlatformImplAndroid,
+ Integer.parseInt(utteranceId));
+ }
+ }
+ });
+ }
+
+ /**
+ * This is overridden by LollipopTtsPlatformImpl because the API changed.
+ */
+ @SuppressWarnings("deprecation")
+ protected void addOnUtteranceProgressListener() {
+ mTextToSpeech.setOnUtteranceProgressListener(new UtteranceProgressListener() {
+ @Override
+ public void onDone(final String utteranceId) {
+ sendEndEventOnUiThread(utteranceId);
+ }
+
+ // This is deprecated in Lollipop and higher but we still need to catch it
+ // on pre-Lollipop builds.
+ @Override
+ @SuppressWarnings("deprecation")
+ public void onError(final String utteranceId) {
+ sendErrorEventOnUiThread(utteranceId);
+ }
+
+ @Override
+ public void onStart(final String utteranceId) {
+ sendStartEventOnUiThread(utteranceId);
+ }
+ });
+ }
+
+ /**
+ * This is overridden by LollipopTtsPlatformImpl because the API changed.
+ */
+ @SuppressWarnings("deprecation")
+ protected int callSpeak(String text, float volume, int utteranceId) {
+ HashMap<String, String> params = new HashMap<String, String>();
+ if (volume != 1.0) {
+ params.put(TextToSpeech.Engine.KEY_PARAM_VOLUME, Double.toString(volume));
+ }
+ params.put(TextToSpeech.Engine.KEY_PARAM_UTTERANCE_ID, Integer.toString(utteranceId));
+ return mTextToSpeech.speak(text, TextToSpeech.QUEUE_FLUSH, params);
+ }
+
+ /**
* Note: we enforce that this method is called on the UI thread, so
* we can call nativeVoicesChanged directly.
*/
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/LollipopTtsPlatformImpl.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698