sky/engine/core/animation/ElementAnimation.idl - Issue 922893002: Merge the Sky Engine changes from the SkyDart branch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/animation/ElementAnimation.idl

Issue 922893002: Merge the Sky Engine changes from the SkyDart branch (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/animation/ElementAnimation.idl

diff --git a/sky/engine/core/animation/ElementAnimation.idl b/sky/engine/core/animation/ElementAnimation.idl

index e06c747dc92489cc401e6b0b5caf716a65fa5ef6..94b62fea6d88521e89eec52b1a00caea49bfa7dc 100644

--- a/sky/engine/core/animation/ElementAnimation.idl

+++ b/sky/engine/core/animation/ElementAnimation.idl

@@ -35,6 +35,6 @@

partial interface Element {

// FIXME: needs support for union types http://crbug.com/240176

// AnimationPlayer animate((AnimationEffect or sequence<Dictionary>)? effect, optional (double or Dictionary) timing);

- [Custom, RaisesException] AnimationPlayer animate(object effect, optional object timing);

+ // [Custom, RaisesException] AnimationPlayer animate(object effect, optional object timing);

sequence<AnimationPlayer> getAnimationPlayers();

};