Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 922403002: [Extensions] Adjust script injection reporting to the browser side (Closed)

Created:
5 years, 10 months ago by Devlin
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Adjust script injection reporting to the browser side Since we can now have active script restriction without the scripts-require- action switch, we need to adjust the reporting criteria for scripts injecting. BUG=452756 Committed: https://crrev.com/958e9f8cbb1affe884fc7af34131ebc5451723f3 Cr-Commit-Position: refs/heads/master@{#316664}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -44 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/active_script_controller.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_util.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_util.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/extensions/permissions_updater.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/permissions_data.h View 1 chunk +8 lines, -0 lines 0 comments Download
M extensions/common/permissions/permissions_data.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M extensions/renderer/extension_injection_host.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/extension_injection_host.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M extensions/renderer/injection_host.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/renderer/script_injection.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/renderer/script_injection.cc View 1 5 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Devlin
5 years, 10 months ago (2015-02-13 20:12:23 UTC) #2
not at google - send to devlin
lgtm https://codereview.chromium.org/922403002/diff/1/extensions/renderer/script_injection.cc File extensions/renderer/script_injection.cc (right): https://codereview.chromium.org/922403002/diff/1/extensions/renderer/script_injection.cc#newcode158 extensions/renderer/script_injection.cc:158: // Make them happy. (btw: not really, it's ...
5 years, 10 months ago (2015-02-13 23:09:33 UTC) #3
Devlin
https://codereview.chromium.org/922403002/diff/1/extensions/renderer/script_injection.cc File extensions/renderer/script_injection.cc (right): https://codereview.chromium.org/922403002/diff/1/extensions/renderer/script_injection.cc#newcode158 extensions/renderer/script_injection.cc:158: // Make them happy. On 2015/02/13 23:09:32, kalman wrote: ...
5 years, 10 months ago (2015-02-17 21:52:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922403002/40001
5 years, 10 months ago (2015-02-17 21:52:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 10 months ago (2015-02-17 21:57:22 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 21:58:17 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/958e9f8cbb1affe884fc7af34131ebc5451723f3
Cr-Commit-Position: refs/heads/master@{#316664}

Powered by Google App Engine
This is Rietveld 408576698