chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 922403002: [Extensions] Adjust script injection reporting to the browser side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 922403002: [Extensions] Adjust script injection reporting to the browser side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index 74c8a42627b9d5ece0495cdb83ae0703c82c4079..22c64dc588418fbd3a03937c9fada0ff6d1e2e05 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -343,7 +343,7 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(

content::BrowserContext* context = extension_service_->GetBrowserContext();

bool show_all_urls =

(FeatureSwitch::scripts_require_action()->IsEnabled() &&

- util::ScriptsMayRequireActionForExtension(

+ PermissionsData::ScriptsMayRequireActionForExtension(

extension,

extension->permissions_data()->active_permissions().get())) ||

extension->permissions_data()->HasWithheldImpliedAllHosts() ||

« no previous file with comments | « chrome/browser/extensions/permissions_updater.cc ('k') | extensions/common/permissions/permissions_data.h » ('j') | no next file with comments »