Enable UMA log uploads for cellular networks.

components/metrics/metrics_service.h

Index: components/metrics/metrics_service.h
diff --git a/components/metrics/metrics_service.h b/components/metrics/metrics_service.h
index 904147454ed490eafc424edf046475a15db67d24..64fe71c0f080b8f5b83a949a6ebdd89cd319541f 100644
--- a/components/metrics/metrics_service.h
+++ b/components/metrics/metrics_service.h
@@ -27,6 +27,7 @@
 #include "components/metrics/metrics_log.h"
 #include "components/metrics/metrics_log_manager.h"
 #include "components/metrics/metrics_provider.h"
+#include "components/metrics/net/network_metrics_provider.h"
 #include "components/variations/active_field_trials.h"
 
 class MetricsServiceAccessor;
@@ -242,6 +243,18 @@ class MetricsService : public base::HistogramFlattener {
   // Clears the stability metrics that are saved in local state.
   void ClearSavedStabilityMetrics();
 
+  // Sets the pointer for network_metrics_provider for passing it through to
+  // scheduler when it is initialized.

[Alexei Svitkine (slow), 2015/02/18 22:03:09]

This is describing implementation details.

I think it can just be:

// Sets the network network provider and registers as a provider.

[gayane -on leave until 09-2017, 2015/02/19 16:24:35]

Done.

+  void SetNetworkMetricsProvider(
+      scoped_ptr<NetworkMetricsProvider> network_metrics_provider);
+
+  // Returns true if the connection type is 2G, 3G, or 4G.
+  bool IsCellularConnection();
+
+  // Assigns the passed |is_cellular_out| parameter whether current network

[Alexei Svitkine (slow), 2015/02/18 22:03:09]

Nit: wording, "based on whether the current network connection is cellular."

[gayane -on leave until 09-2017, 2015/02/19 16:24:35]

Done.

+  // connection is cellular.
+  void GetIsCellularConnection(bool* is_cellular_out);
+
  protected:
   // Exposed for testing.
   MetricsLogManager* log_manager() { return &log_manager_; }
@@ -481,6 +494,8 @@ class MetricsService : public base::HistogramFlattener {
   // exited-cleanly bit in the prefs.
   static ShutdownCleanliness clean_shutdown_status_;
 
+  const NetworkMetricsProvider* network_metrics_provider_;

[Alexei Svitkine (slow), 2015/02/18 22:03:09]

Add a comment.

[gayane -on leave until 09-2017, 2015/02/19 16:24:35]

Done.

+
   FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, IsPluginProcess);
   FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest,
                            PermutedEntropyCacheClearedWhenLowEntropyReset);