Enable UMA log uploads for cellular networks.

components/metrics/metrics_service.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines a service that collects information about the user
 // experience in order to help improve future versions of the app.
 
 #ifndef COMPONENTS_METRICS_METRICS_SERVICE_H_
 #define COMPONENTS_METRICS_METRICS_SERVICE_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/memory/weak_ptr.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram_flattener.h"
 #include "base/metrics/histogram_snapshot_manager.h"
 #include "base/metrics/user_metrics.h"
 #include "base/observer_list.h"
 #include "base/time/time.h"
 #include "components/metrics/clean_exit_beacon.h"
 #include "components/metrics/metrics_log.h"
 #include "components/metrics/metrics_log_manager.h"
 #include "components/metrics/metrics_provider.h"
+#include "components/metrics/net/network_metrics_provider.h"
 #include "components/variations/active_field_trials.h"
 
 class MetricsServiceAccessor;
 class PrefService;
 class PrefRegistrySimple;
 
 namespace base {
 class DictionaryValue;
 class HistogramSamples;
 class MessageLoopProxy;
@@ skipping 195 matching lines @@
 
   // Check if this install was cloned or imaged from another machine. If a
   // clone is detected, reset the client id and low entropy source. This
   // should not be called more than once.
   void CheckForClonedInstall(
       scoped_refptr<base::SingleThreadTaskRunner> task_runner);
 
   // Clears the stability metrics that are saved in local state.
   void ClearSavedStabilityMetrics();
 
+  // Sets the pointer for network_metrics_provider for passing it through to
+  // scheduler when it is initialized.

[Alexei Svitkine (slow), 2015/02/18 22:03:09]

This is describing implementation details.

I think it can just be:

// Sets the network network provider and registers as a provider.

[gayane -on leave until 09-2017, 2015/02/19 16:24:35]

Done.

+  void SetNetworkMetricsProvider(
+      scoped_ptr<NetworkMetricsProvider> network_metrics_provider);
+
+  // Returns true if the connection type is 2G, 3G, or 4G.
+  bool IsCellularConnection();
+
+  // Assigns the passed |is_cellular_out| parameter whether current network

[Alexei Svitkine (slow), 2015/02/18 22:03:09]

Nit: wording, "based on whether the current network connection is cellular."

[gayane -on leave until 09-2017, 2015/02/19 16:24:35]

Done.

+  // connection is cellular.
+  void GetIsCellularConnection(bool* is_cellular_out);
+
  protected:
   // Exposed for testing.
   MetricsLogManager* log_manager() { return &log_manager_; }
 
  private:
   // The MetricsService has a lifecycle that is stored as a state.
   // See metrics_service.cc for description of this lifecycle.
   enum State {
     INITIALIZED,                    // Constructor was called.
     INIT_TASK_SCHEDULED,            // Waiting for deferred init tasks to
@@ skipping 219 matching lines @@
   // List of observers of |synthetic_trial_groups_| changes.
   ObserverList<SyntheticTrialObserver> synthetic_trial_observer_list_;
 
   // Execution phase the browser is in.
   static ExecutionPhase execution_phase_;
 
   // Reduntant marker to check that we completed our shutdown, and set the
   // exited-cleanly bit in the prefs.
   static ShutdownCleanliness clean_shutdown_status_;
 
+  const NetworkMetricsProvider* network_metrics_provider_;

[Alexei Svitkine (slow), 2015/02/18 22:03:09]

Add a comment.

[gayane -on leave until 09-2017, 2015/02/19 16:24:35]

Done.

+
   FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, IsPluginProcess);
   FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest,
                            PermutedEntropyCacheClearedWhenLowEntropyReset);
   FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, RegisterSyntheticTrial);
 
   // Weak pointers factory used to post task on different threads. All weak
   // pointers managed by this factory have the same lifetime as MetricsService.
   base::WeakPtrFactory<MetricsService> self_ptr_factory_;
 
   // Weak pointers factory used for saving state. All weak pointers managed by
   // this factory are invalidated in ScheduleNextStateSave.
   base::WeakPtrFactory<MetricsService> state_saver_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MetricsService);
 };
 
 }  // namespace metrics
 
 #endif  // COMPONENTS_METRICS_METRICS_SERVICE_H_