|
|
Created:
5 years, 10 months ago by xdai1 Modified:
5 years, 9 months ago CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake API chrome.wallpaper.setWallpaper exposed on stable channel.
BUG=176183
Committed: https://crrev.com/ffb528ebbdaf2cf7c4723403d2853a7c8897748c
Cr-Commit-Position: refs/heads/master@{#317835}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Address code review comment. #Messages
Total messages: 18 (5 generated)
xdai@chromium.org changed reviewers: + bshe@chromium.org, mkwst@chromium.org
Please take a look, thanks!
mkwst@chromium.org changed reviewers: + kalman@chromium.org
Sorry, I'm only in the OWNERS file for documentation changes. You'll need to talk to kalman@, et al. to get approval to launch new features.
https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api... File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api... chrome/common/extensions/api/_permission_features.json:943: "extension_types": ["platform_app"], This has come up many times before, but we can make this extensions as well?
On 2015/02/17 18:44:13, kalman wrote: > https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api... > File chrome/common/extensions/api/_permission_features.json (right): > > https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api... > chrome/common/extensions/api/_permission_features.json:943: "extension_types": > ["platform_app"], > This has come up many times before, but we can make this extensions as well? Yes. It should be safe to make it available to extension. I forgot to mention it to xdai1
On 2015/02/17 18:45:46, bshe wrote: > On 2015/02/17 18:44:13, kalman wrote: > > > https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api... > > File chrome/common/extensions/api/_permission_features.json (right): > > > > > https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api... > > chrome/common/extensions/api/_permission_features.json:943: "extension_types": > > ["platform_app"], > > This has come up many times before, but we can make this extensions as well? > > Yes. It should be safe to make it available to extension. I forgot to mention it > to xdai1 kalman@, bshe@, thanks for the review! Please take another look.
On 2015/02/19 00:01:08, xdai1 wrote: > On 2015/02/17 18:45:46, bshe wrote: > > On 2015/02/17 18:44:13, kalman wrote: > > > > > > https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api... > > > File chrome/common/extensions/api/_permission_features.json (right): > > > > > > > > > https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api... > > > chrome/common/extensions/api/_permission_features.json:943: > "extension_types": > > > ["platform_app"], > > > This has come up many times before, but we can make this extensions as well? > > > > Yes. It should be safe to make it available to extension. I forgot to mention > it > > to xdai1 > > kalman@, bshe@, thanks for the review! Please take another look. ping?
On 2015/02/23 17:59:34, xdai1 wrote: > On 2015/02/19 00:01:08, xdai1 wrote: > > On 2015/02/17 18:45:46, bshe wrote: > > > On 2015/02/17 18:44:13, kalman wrote: > > > > > > > > > > https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api... > > > > File chrome/common/extensions/api/_permission_features.json (right): > > > > > > > > > > > > > > https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api... > > > > chrome/common/extensions/api/_permission_features.json:943: > > "extension_types": > > > > ["platform_app"], > > > > This has come up many times before, but we can make this extensions as > well? > > > > > > Yes. It should be safe to make it available to extension. I forgot to > mention > > it > > > to xdai1 > > > > kalman@, bshe@, thanks for the review! Please take another look. > > ping? lgtm but you need to wait for kalman's approval.
lgtm
The CQ bit was checked by xdai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922343002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by xdai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922343002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ffb528ebbdaf2cf7c4723403d2853a7c8897748c Cr-Commit-Position: refs/heads/master@{#317835} |