Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 922343002: Make API chrome.wallpaper.setWallpaper exposed on stable channel. (Closed)

Created:
5 years, 10 months ago by xdai1
Modified:
5 years, 9 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make API chrome.wallpaper.setWallpaper exposed on stable channel. BUG=176183 Committed: https://crrev.com/ffb528ebbdaf2cf7c4723403d2853a7c8897748c Cr-Commit-Position: refs/heads/master@{#317835}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address code review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
xdai1
Please take a look, thanks!
5 years, 10 months ago (2015-02-14 01:25:24 UTC) #2
Mike West
Sorry, I'm only in the OWNERS file for documentation changes. You'll need to talk to ...
5 years, 10 months ago (2015-02-14 06:07:12 UTC) #4
not at google - send to devlin
https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api/_permission_features.json#newcode943 chrome/common/extensions/api/_permission_features.json:943: "extension_types": ["platform_app"], This has come up many times before, ...
5 years, 10 months ago (2015-02-17 18:44:13 UTC) #5
bshe
On 2015/02/17 18:44:13, kalman wrote: > https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api/_permission_features.json > File chrome/common/extensions/api/_permission_features.json (right): > > https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api/_permission_features.json#newcode943 > ...
5 years, 10 months ago (2015-02-17 18:45:46 UTC) #6
xdai1
On 2015/02/17 18:45:46, bshe wrote: > On 2015/02/17 18:44:13, kalman wrote: > > > https://codereview.chromium.org/922343002/diff/1/chrome/common/extensions/api/_permission_features.json ...
5 years, 10 months ago (2015-02-19 00:01:08 UTC) #7
xdai1
On 2015/02/19 00:01:08, xdai1 wrote: > On 2015/02/17 18:45:46, bshe wrote: > > On 2015/02/17 ...
5 years, 10 months ago (2015-02-23 17:59:34 UTC) #8
bshe
On 2015/02/23 17:59:34, xdai1 wrote: > On 2015/02/19 00:01:08, xdai1 wrote: > > On 2015/02/17 ...
5 years, 10 months ago (2015-02-23 18:19:56 UTC) #9
not at google - send to devlin
lgtm
5 years, 10 months ago (2015-02-23 18:23:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922343002/20001
5 years, 10 months ago (2015-02-23 18:25:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61773)
5 years, 10 months ago (2015-02-23 18:28:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922343002/20001
5 years, 9 months ago (2015-02-24 18:09:51 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-24 18:30:03 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-02-24 18:33:59 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ffb528ebbdaf2cf7c4723403d2853a7c8897748c
Cr-Commit-Position: refs/heads/master@{#317835}

Powered by Google App Engine
This is Rietveld 408576698