Clean up isolate tests.

Clean up isolate tests.

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30761

[floitsch, 2013-11-27 18:45:03]

Most of the negative tests had already multi-tests. That's why I could just
delete them.

[kustermann, 2013-11-28 09:19:47]

lgtm with comments

https://codereview.chromium.org/92223003/diff/1/tests/isolate/compile_time_er...
File tests/isolate/compile_time_error_test.dart (right):

https://codereview.chromium.org/92223003/diff/1/tests/isolate/compile_time_er...
tests/isolate/compile_time_error_test.dart:17: : fld2 = fld1  /// 01:
compile-time error
If this results in a compile-time error in the isolate but in a runtime error in
the main isolate, how can we detect that?

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate.status
File tests/isolate/isolate.status (right):

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate.status#...
tests/isolate/isolate.status:79: unresolved_test/01: CompileTimeError
I cannot see that test in your CL. Is it missing?

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate.status#...
tests/isolate/isolate.status:80: isolate_import_test/01: StaticWarning
This is a valid warning, see comment in the file.

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate_import_...
File tests/isolate/isolate_import_test.dart (right):

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate_import_...
tests/isolate/isolate_import_test.dart:7: /*  /// 01: runtime error
It should look like:
  /// 01: runtime error, static type warning

Since it will give a valid warning when running dartanalyzer on it (but double
check in the spec that it's supposed to give a warning [and not an error]).

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate_throws_...
File tests/isolate/isolate_throws_test.dart (right):

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate_throws_...
tests/isolate/isolate_throws_test.dart:8: import 'dart:isolate';
Keep imports sorted.

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate_throws_...
tests/isolate/isolate_throws_test.dart:22: asyncEnd();
For the positive test (i.e. the /none test), you should assert here that you get
"done" back.

https://codereview.chromium.org/92223003/diff/1/tests/isolate/spawn_uri_vm_ne...
File tests/isolate/spawn_uri_vm_negative_test.dart (left):

https://codereview.chromium.org/92223003/diff/1/tests/isolate/spawn_uri_vm_ne...
tests/isolate/spawn_uri_vm_negative_test.dart:20:
Isolate.spawnUri(Uri.parse('spawn_uri_child_isolate.dart'),
You didn't add a test for Isolate.spawnUri if I see it correctly.

[floitsch, 2013-11-28 14:35:25]

https://codereview.chromium.org/92223003/diff/1/tests/isolate/compile_time_er...
File tests/isolate/compile_time_error_test.dart (right):

https://codereview.chromium.org/92223003/diff/1/tests/isolate/compile_time_er...
tests/isolate/compile_time_error_test.dart:17: : fld2 = fld1  /// 01:
compile-time error
On 2013/11/28 09:19:47, kustermann wrote:
> If this results in a compile-time error in the isolate but in a runtime error
in
> the main isolate, how can we detect that?

As discussed in person: we will have to decide what should happen, and how we
should test for it.
Currently this test is skipped for the VM anyway.

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate.status
File tests/isolate/isolate.status (right):

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate.status#...
tests/isolate/isolate.status:79: unresolved_test/01: CompileTimeError
On 2013/11/28 09:19:47, kustermann wrote:
> I cannot see that test in your CL. Is it missing?

my fault.
removed.

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate.status#...
tests/isolate/isolate.status:80: isolate_import_test/01: StaticWarning
On 2013/11/28 09:19:47, kustermann wrote:
> This is a valid warning, see comment in the file.

Done.

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate_import_...
File tests/isolate/isolate_import_test.dart (right):

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate_import_...
tests/isolate/isolate_import_test.dart:7: /*  /// 01: runtime error
On 2013/11/28 09:19:47, kustermann wrote:
> It should look like:
>   /// 01: runtime error, static type warning
> 
> Since it will give a valid warning when running dartanalyzer on it (but double
> check in the spec that it's supposed to give a warning [and not an error]).

unresolved identifiers are warnings.
thanks, and done.

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate_throws_...
File tests/isolate/isolate_throws_test.dart (right):

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate_throws_...
tests/isolate/isolate_throws_test.dart:8: import 'dart:isolate';
On 2013/11/28 09:19:47, kustermann wrote:
> Keep imports sorted.

Done.

https://codereview.chromium.org/92223003/diff/1/tests/isolate/isolate_throws_...
tests/isolate/isolate_throws_test.dart:22: asyncEnd();
On 2013/11/28 09:19:47, kustermann wrote:
> For the positive test (i.e. the /none test), you should assert here that you
get
> "done" back.

Done.

https://codereview.chromium.org/92223003/diff/1/tests/isolate/spawn_uri_vm_ne...
File tests/isolate/spawn_uri_vm_negative_test.dart (left):

https://codereview.chromium.org/92223003/diff/1/tests/isolate/spawn_uri_vm_ne...
tests/isolate/spawn_uri_vm_negative_test.dart:20:
Isolate.spawnUri(Uri.parse('spawn_uri_child_isolate.dart'),
On 2013/11/28 09:19:47, kustermann wrote:
> You didn't add a test for Isolate.spawnUri if I see it correctly.

Already existed.

[floitsch, 2013-11-28 14:36:42]

Committed patchset #3 manually as r30761 (presubmit successful).

[kustermann, 2013-11-28 15:06:05]

lgtm