Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: tests/isolate/compile_time_error_test.dart

Issue 92223003: Clean up isolate tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/isolate/isolate.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/isolate/compile_time_error_test.dart
diff --git a/tests/isolate/isolate3_negative_test.dart b/tests/isolate/compile_time_error_test.dart
similarity index 50%
rename from tests/isolate/isolate3_negative_test.dart
rename to tests/isolate/compile_time_error_test.dart
index ed46f2785ef921ee4c4258785a54b78e28d44d66..4bb70c7d42b95b3d5861290a6b6ccfacef77d937 100644
--- a/tests/isolate/isolate3_negative_test.dart
+++ b/tests/isolate/compile_time_error_test.dart
@@ -7,28 +7,29 @@
library Isolate3NegativeTest;
import 'dart:isolate';
-import '../../pkg/unittest/lib/unittest.dart';
+import 'dart:async';
+import "package:async_helper/async_helper.dart";
class TestClass {
- TestClass.named(num this.fld1) : fld2=fld1 {
- TestClass.i = 0; // Should cause a compilation error.
- }
+ TestClass.named(num this.fld1)
+ // Should cause a compilation error (for the spawned isolate). It is a
+ // runtime error for the test.
+ : fld2 = fld1 /// 01: compile-time error
+ ;
num fld1;
num fld2;
}
void entry(SendPort replyTo) {
var tmp = new TestClass.named(10);
- replyTo.send(tmp);
+ replyTo.send("done");
}
main() {
- test("child isolate compilation errors propagate correctly. ", () {
- void msg_callback(var message) {
- // This test is a negative test and should not complete successfully.
- }
- ReceivePort response = new ReceivePort();
- Isolate.spawn(entry, response.sendPort);
- response.first.then(expectAsync1(msg_callback));
+ asyncStart();
+ ReceivePort response = new ReceivePort();
+ Isolate.spawn(entry, response.sendPort);
+ response.first.then((_) {
+ asyncEnd();
});
}
« no previous file with comments | « no previous file | tests/isolate/isolate.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698