Issue 922023003: Revert of Add task location information to WorkerThread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 922023003: Revert of Add task location information to WorkerThread (Closed)

Created:
5 years, 10 months ago by Ken Russell (switch to Gerrit)

Modified:
5 years, 10 months ago

Reviewers:
haraken, Sami

CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Add task location information to WorkerThread (patchset #2 id:20001 of https://codereview.chromium.org/899923004/) Reason for revert: Collided with a revert of dependent patch https://codereview.chromium.org/941403002 . Original issue's description: > Add task location information to WorkerThread > > BUG=450977 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190594 TBR=haraken@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450977 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190598

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -33 lines)			Patch
M	Source/core/workers/WorkerGlobalScope.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/workers/WorkerInspectorProxy.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/workers/WorkerMessagingProxy.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/workers/WorkerThread.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/workers/WorkerThread.cpp	View	5 chunks	+19 lines, -19 lines	0 comments	Download
M	Source/web/WebEmbeddedWorkerImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebSharedWorkerImpl.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/web/WebWorkerRunLoop.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Ken Russell (switch to Gerrit)

Created Revert of Add task location information to WorkerThread

5 years, 10 months ago (2015-02-20 23:02:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922023003/1

5 years, 10 months ago (2015-02-20 23:03:53 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190598

5 years, 10 months ago (2015-02-20 23:04:36 UTC) #3

Message was sent while issue was closed.

LGTM, thanks for the gardening!