Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 941403002: Revert of Add task location information to ExecutionContext (Closed)

Created:
5 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 10 months ago
Reviewers:
haraken, Sami
CC:
blink-reviews, tzik, sof, eae+blinkwatch, tommyw+watchlist_chromium.org, nhiroki, Raymond Toy, falken, blink-reviews-dom_chromium.org, dglazkov+blink, kinuko+worker_chromium.org, horo+watch_chromium.org, kinuko+fileapi, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Add task location information to ExecutionContext (patchset #2 id:20001 of https://codereview.chromium.org/915703002/) Reason for revert: Seems to have introduced memory errors. See crbug.com/460533 . Original issue's description: > Add task location information to ExecutionContext > > BUG=450977 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190568 TBR=haraken@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450977 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -76 lines) Patch
M Source/core/dom/Document.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StringCallback.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/fileapi/FileReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/NetworkStateNotifier.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/NullExecutionContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/NullExecutionContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerEventQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerObjectProxy.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DOMFileSystem.h View 7 chunks +6 lines, -7 lines 0 comments Download
M Source/modules/filesystem/LocalFileSystem.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/DeprecatedStorageInfo.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageQuota.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioScheduledSourceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/Database.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseTracker.cpp View 4 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/webdatabase/SQLTransactionClient.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/StorageQuotaClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Created Revert of Add task location information to ExecutionContext
5 years, 10 months ago (2015-02-20 19:26:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941403002/1
5 years, 10 months ago (2015-02-20 19:27:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190579
5 years, 10 months ago (2015-02-20 19:28:39 UTC) #3
haraken
5 years, 10 months ago (2015-02-20 19:43:56 UTC) #4
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698