Issue 921883003: Change QuicFramer so it accepts a QuicDataWriter rather than allocating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 921883003: Change QuicFramer so it accepts a QuicDataWriter rather than allocating (Closed)

Created:
5 years, 10 months ago by ramant (doing other things)

Modified:
5 years, 10 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Deprecate_flag_quic_use_std_cbrt

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Change QuicFramer so it accepts a QuicDataWriter rather than allocating one. Saves a full packet allocation by putting it on the stack. Merge internal change: 86104715 R=rch@chromium.org

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+107 lines, -78 lines)			Patch
M	net/quic/crypto/crypto_framer.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	net/quic/quic_data_writer.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	net/quic/quic_data_writer.cc	View	1 chunk	+4 lines, -11 lines	0 comments	Download
M	net/quic/quic_data_writer_test.cc	View	4 chunks	+17 lines, -16 lines	0 comments	Download
M	net/quic/quic_framer.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/quic/quic_framer.cc	View	9 chunks	+26 lines, -28 lines	0 comments	Download
M	net/quic/quic_framer_test.cc	View	5 chunks	+10 lines, -7 lines	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	3 chunks	+16 lines, -4 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	net/quic/test_tools/quic_test_utils.cc	View	2 chunks	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages