net/quic/quic_framer.h - Issue 921883003: Change QuicFramer so it accepts a QuicDataWriter rather than allocating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_framer.h

Issue 921883003: Change QuicFramer so it accepts a QuicDataWriter rather than allocating (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Deprecate_flag_quic_use_std_cbrt

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_framer.h

diff --git a/net/quic/quic_framer.h b/net/quic/quic_framer.h

index abd2e31d1f587bbec6659cf25b28c94ba190e407..3cfaa88d37201bd1dfd5892b4752b9a4eb4d3d54 100644

--- a/net/quic/quic_framer.h

+++ b/net/quic/quic_framer.h

@@ -306,7 +306,8 @@ class NET_EXPORT_PRIVATE QuicFramer {

// The packet must be of size |packet_size|.

QuicPacket* BuildDataPacket(const QuicPacketHeader& header,

const QuicFrames& frames,

- size_t packet_size);

+ char* buffer,

+ size_t packet_length);

// Returns a QuicPacket* that is owned by the caller, and is populated with

// the fields in |header| and |fec|. Returns nullptr if the packet could

« no previous file with comments | « net/quic/quic_data_writer_test.cc ('k') | net/quic/quic_framer.cc » ('j') | no next file with comments »