Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 921823002: Use SVGLength-references in the SVGLengthContext API (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, krit, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use SVGLength-references in the SVGLengthContext API Convert all the PassRefPtrWillBeRawPtr<SVGLength>-typed arguments to const SVGLength&. This avoids unnecessary ref-count churn (the caller will always own a reference anyway). As a side-effect footprint is reduced by ~2k. (resolveRectangle<T> can now be properly inlined and other methods shrink a bit.) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -33 lines) Patch
M Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourcePattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceRadialGradient.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGLengthContext.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGLengthContext.cpp View 1 chunk +12 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 10 months ago (2015-02-12 17:49:20 UTC) #2
pdr.
LGTM I learned about GradientAttributes while reviewing this... such complexity, much wow. No change needed ...
5 years, 10 months ago (2015-02-12 20:00:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921823002/1
5 years, 10 months ago (2015-02-12 20:01:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190070
5 years, 10 months ago (2015-02-12 20:04:04 UTC) #6
fs
5 years, 10 months ago (2015-02-13 09:56:56 UTC) #7
Message was sent while issue was closed.
On 2015/02/12 20:00:59, pdr wrote:
...
> I learned about GradientAttributes while reviewing this... such complexity,
much
> wow. No change needed in this patch, just venting..

I can only agree...

Powered by Google App Engine
This is Rietveld 408576698