Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 921813002: Fix template angle bracket syntax in bindings (Closed)

Created:
5 years, 10 months ago by rwlbuis
Modified:
5 years, 10 months ago
Reviewers:
haraken, vivekg
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix template angle bracket syntax in bindings In C++11 the parser is able to parse >> as the end of the template argument list. BUG=449681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -122 lines) Patch
M Source/bindings/core/v8/DOMDataStore.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/DOMWrapperWorld.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/DOMWrapperWorld.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/DictionaryHelperForCore.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScheduledAction.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScheduledAction.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptController.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptController.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptPreprocessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptPromisePropertyBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptPromisePropertyBase.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromisePropertyTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptStreamer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptString.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptValueSerializer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/SharedPersistent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ToV8Test.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 12 chunks +25 lines, -25 lines 0 comments Download
M Source/bindings/core/v8/V8BindingTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8DOMActivityLogger.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8GCController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8MutationCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8MutationCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8NPObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8PerContextData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8PerIsolateData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8PersistentValueMap.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/WindowProxyManager.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/modules/v8/IDBBindingUtilities.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/TestDictionary.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestCallbackInterface.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestCallbackInterface.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 18 chunks +18 lines, -18 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestTypedefs.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
rwlbuis
PTAL. All changes done with a perl oneliner, except for the python script change which ...
5 years, 10 months ago (2015-02-12 20:23:50 UTC) #2
vivekg
Non owner lgtm. Makes the code look beautiful thereby less stress on eyes. hehe :)
5 years, 10 months ago (2015-02-13 00:18:28 UTC) #4
haraken
LGTM
5 years, 10 months ago (2015-02-13 01:18:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921813002/1
5 years, 10 months ago (2015-02-13 02:16:40 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 04:38:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190103

Powered by Google App Engine
This is Rietveld 408576698