Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 92173003: Proper initialization for known_disabled. (Closed)

Created:
7 years ago by gab
Modified:
7 years ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Proper initialization for known_disabled. As of http://crrev.com/237473 we can finally have proper initialization of this code path (before we would have no way to tell the difference between a user who has never initialized and one which initialized to an empty list which was pruned out on write). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238285

Patch Set 1 #

Patch Set 2 : +DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -37 lines) Patch
M chrome/browser/extensions/extension_prefs.h View 2 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 2 chunks +24 lines, -15 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 8 chunks +24 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gab
Yoyo, PTAL. Thanks! Gab
7 years ago (2013-11-27 19:33:49 UTC) #1
gab
On 2013/11/27 19:33:49, gab wrote: > Yoyo, PTAL. ping > > Thanks! > Gab
7 years ago (2013-12-02 18:04:34 UTC) #2
Yoyo Zhou
LGTM
7 years ago (2013-12-02 21:43:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/92173003/20001
7 years ago (2013-12-02 22:07:49 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195599
7 years ago (2013-12-03 00:28:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/92173003/20001
7 years ago (2013-12-03 00:35:00 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-03 03:17:29 UTC) #7
Message was sent while issue was closed.
Change committed as 238285

Powered by Google App Engine
This is Rietveld 408576698