Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: chrome/browser/extensions/extension_prefs.h

Issue 92173003: Proper initialization for known_disabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: +DCHECK Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_prefs.h
diff --git a/chrome/browser/extensions/extension_prefs.h b/chrome/browser/extensions/extension_prefs.h
index f7130a59fdc44f84792da61b3c372c0e5796641d..0833e6a3afbfbe001873b6f2cb8b205c94145b95 100644
--- a/chrome/browser/extensions/extension_prefs.h
+++ b/chrome/browser/extensions/extension_prefs.h
@@ -179,8 +179,11 @@ class ExtensionPrefs : public ExtensionScopedPrefs,
ExtensionIdList GetToolbarOrder();
void SetToolbarOrder(const ExtensionIdList& extension_ids);
- // Get/Set the list of known disabled extension IDs.
- ExtensionIdSet GetKnownDisabled();
+ // Gets the set of known disabled extension IDs into |id_set_out|. Returns
+ // false iff the set of known disabled extension IDs hasn't been set yet.
+ bool GetKnownDisabled(ExtensionIdSet* id_set_out);
+
+ // Sets the set of known disabled extension IDs.
void SetKnownDisabled(const ExtensionIdSet& extension_ids);
// Called when an extension is installed, so that prefs get created.
@@ -605,10 +608,13 @@ class ExtensionPrefs : public ExtensionScopedPrefs,
bool DoesExtensionHaveState(const std::string& id,
Extension::State check_state) const;
- // Reads the list of strings for |pref| from prefs into an
- // ExtensionIdContainer.
+ // Reads the list of strings for |pref| from user prefs into
+ // |id_container_out|. Returns false if the pref wasn't found in the user
+ // pref store.
template <class ExtensionIdContainer>
- ExtensionIdContainer GetExtensionPrefAsContainer(const char* pref);
+ bool GetUserExtensionPrefIntoContainer(
+ const char* pref,
+ ExtensionIdContainer* id_container_out);
// Writes the list of strings contained in |strings| to |pref| in prefs.
template <class ExtensionIdContainer>
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698