Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6466)

Unified Diff: chrome_frame/test_utils.cc

Issue 92173002: Merge 237541 "Revert of https://codereview.chromium.org/71013004/" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1721/src/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/test/chrome_frame_test_utils.cc ('k') | cloud_print/service/win/chrome_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test_utils.cc
===================================================================
--- chrome_frame/test_utils.cc (revision 237598)
+++ chrome_frame/test_utils.cc (working copy)
@@ -88,7 +88,7 @@
int entrypoint_index = 0;
base::LaunchOptions launch_options;
- base::win::ScopedHandle process_handle;
+ base::ProcessHandle process_handle = INVALID_HANDLE_VALUE;
int exit_code = -1;
if (registration_type == PER_USER)
@@ -111,12 +111,13 @@
<< "Failed to register or unregister DLL with command: "
<< registration_command;
} else {
+ base::win::ScopedHandle rundll32(process_handle);
if (!base::WaitForExitCodeWithTimeout(
- process_handle.Get(), &exit_code,
+ process_handle, &exit_code,
base::TimeDelta::FromMilliseconds(kDllRegistrationTimeoutMs))) {
LOG(ERROR) << "Timeout waiting to register or unregister DLL with "
"command: " << registration_command;
- base::KillProcess(process_handle.Get(), 0, false);
+ base::KillProcess(process_handle, 0, false);
NOTREACHED() << "Aborting test due to registration failure.";
}
}
« no previous file with comments | « chrome_frame/test/chrome_frame_test_utils.cc ('k') | cloud_print/service/win/chrome_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698