Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8372)

Unified Diff: chrome_frame/test/chrome_frame_test_utils.cc

Issue 92173002: Merge 237541 "Revert of https://codereview.chromium.org/71013004/" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1721/src/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/ready_mode/internal/registry_ready_mode_state.cc ('k') | chrome_frame/test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/chrome_frame_test_utils.cc
===================================================================
--- chrome_frame/test/chrome_frame_test_utils.cc (revision 237598)
+++ chrome_frame/test/chrome_frame_test_utils.cc (working copy)
@@ -640,7 +640,7 @@
return NULL;
}
- base::win::ScopedHandle crash_service;
+ base::ProcessHandle crash_service = NULL;
VLOG(1) << "Starting crash_service.exe so you know if a test crashes!";
@@ -656,7 +656,7 @@
if (DetectRunningCrashService(kCrashServiceStartupTimeoutMs)) {
VLOG(1) << "crash_service.exe is ready for clients in "
<< (base::Time::Now() - start).InMilliseconds() << " ms.";
- return crash_service.Take();
+ return crash_service;
} else {
LOG(ERROR) << "crash_service.exe failed to accept client connections "
"within " << kCrashServiceStartupTimeoutMs << " ms. "
@@ -664,8 +664,8 @@
// First check to see if it's even still running just to minimize the
// likelihood of spurious error messages from KillProcess.
- if (WAIT_OBJECT_0 != ::WaitForSingleObject(crash_service.Get(), 0)) {
- base::KillProcess(crash_service.Get(), 0, false);
+ if (WAIT_OBJECT_0 != ::WaitForSingleObject(crash_service, 0)) {
+ base::KillProcess(crash_service, 0, false);
}
return NULL;
}
« no previous file with comments | « chrome_frame/ready_mode/internal/registry_ready_mode_state.cc ('k') | chrome_frame/test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698