Issue 921633003: Ensure the OOP PDF page indicator doesn't get displayed if there are no scrollbars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 921633003: Ensure the OOP PDF page indicator doesn't get displayed if there are no scrollbars. (Closed)

Created:
5 years, 10 months ago by raymes

Modified:
5 years, 10 months ago

Reviewers:
Sam McNally

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Ensure the OOP PDF page indicator doesn't get displayed if there are no scrollbars. This regressed in https://codereview.chromium.org/898673003 BUG=458381 Committed: https://crrev.com/e52d023854d50a06d6fd0b6af55ce70650f41c8b Cr-Commit-Position: refs/heads/master@{#316143}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	chrome/browser/resources/pdf/pdf.js	View	1	2 chunks	+2 lines, -6 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921633003/20001

5 years, 10 months ago (2015-02-13 01:42:35 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-13 03:02:27 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/e52d023854d50a06d6fd0b6af55ce70650f41c8b
Cr-Commit-Position: refs/heads/master@{#316143}