Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: chrome/browser/resources/pdf/pdf.js

Issue 921633003: Ensure the OOP PDF page indicator doesn't get displayed if there are no scrollbars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/pdf/pdf.js
diff --git a/chrome/browser/resources/pdf/pdf.js b/chrome/browser/resources/pdf/pdf.js
index eaf96ac6559e17fa4f494b4e89bda07c2d7ff9cf..0069b569db4959a8ceda2cfa37e418c5d51faf81 100644
--- a/chrome/browser/resources/pdf/pdf.js
+++ b/chrome/browser/resources/pdf/pdf.js
@@ -408,8 +408,6 @@ PDFViewer.prototype = {
// Document load complete.
if (this.lastViewportPosition_)
this.viewport_.position = this.lastViewportPosition_;
- if (!this.isMaterial_)
- this.pageIndicator_.style.visibility = 'visible';
this.handleURLParams_();
this.loaded_ = true;
this.sendScriptingMessage_({
@@ -609,12 +607,10 @@ PDFViewer.prototype = {
// Update the page indicator.
var visiblePage = this.viewport_.getMostVisiblePage();
- if (this.isMaterial_)
+ if (this.isMaterial_) {
this.materialToolbar_.pageIndex = visiblePage;
- else
+ } else {
this.pageIndicator_.index = visiblePage;
-
- if (!this.isMaterial_) {
if (this.documentDimensions_.pageDimensions.length > 1 &&
hasScrollbars.vertical) {
this.pageIndicator_.style.visibility = 'visible';
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698