Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 92153002: Move ConfigurationPolicyProvider, etc. to components/policy. (Closed)

Created:
7 years ago by dconnelly
Modified:
7 years ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Move ConfigurationPolicyProvider, etc. to components/policy. This facilitates the refactoring of chrome/browser/policy into a layered component. BUG=271392 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238097

Patch Set 1 #

Total comments: 12

Patch Set 2 : gyp fixes #

Total comments: 2

Patch Set 3 : comma #

Patch Set 4 : don't export from static_library #

Patch Set 5 : link #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -907 lines) Patch
M chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/login_profile_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/proxy_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/proxy_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/async_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/async_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/config_dir_policy_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/configuration_policy_provider.h View 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/browser/policy/configuration_policy_provider.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/policy/configuration_policy_provider_test.h View 1 chunk +0 lines, -152 lines 0 comments Download
D chrome/browser/policy/configuration_policy_provider_test.cc View 1 chunk +0 lines, -403 lines 0 comments Download
M chrome/browser/policy/forwarding_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/forwarding_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/mock_configuration_policy_provider.h View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/policy/mock_configuration_policy_provider.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_loader_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_loader_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_prefs_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_service_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/profile_policy_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prefs/proxy_policy_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/policy_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M components/policy.gypi View 1 2 3 4 2 chunks +33 lines, -2 lines 0 comments Download
A + components/policy/core/common/configuration_policy_provider.h View 3 chunks +7 lines, -5 lines 0 comments Download
A + components/policy/core/common/configuration_policy_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/configuration_policy_provider_test.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + components/policy/core/common/configuration_policy_provider_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/policy/core/common/mock_configuration_policy_provider.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + components/policy/core/common/mock_configuration_policy_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
dconnelly
7 years ago (2013-11-27 18:42:41 UTC) #1
Joao da Silva
https://codereview.chromium.org/92153002/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/92153002/diff/1/chrome/chrome_tests.gypi#newcode901 chrome/chrome_tests.gypi:901: '../components/components.gyp:policy_test_support', This is not needed, if test_support_common exports the ...
7 years ago (2013-11-28 07:59:36 UTC) #2
dconnelly
https://codereview.chromium.org/92153002/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/92153002/diff/1/chrome/chrome_tests.gypi#newcode901 chrome/chrome_tests.gypi:901: '../components/components.gyp:policy_test_support', On 2013/11/28 07:59:36, Joao da Silva wrote: > ...
7 years ago (2013-11-29 10:52:26 UTC) #3
Joao da Silva
lgtm https://codereview.chromium.org/92153002/diff/20001/components/policy.gypi File components/policy.gypi (right): https://codereview.chromium.org/92153002/diff/20001/components/policy.gypi#newcode76 components/policy.gypi:76: 'POLICY_COMPONENT_IMPLEMENTATION' nitty nit: add a trailing comma, for ...
7 years ago (2013-11-29 12:14:11 UTC) #4
dconnelly
https://codereview.chromium.org/92153002/diff/20001/components/policy.gypi File components/policy.gypi (right): https://codereview.chromium.org/92153002/diff/20001/components/policy.gypi#newcode76 components/policy.gypi:76: 'POLICY_COMPONENT_IMPLEMENTATION' On 2013/11/29 12:14:12, Joao da Silva wrote: > ...
7 years ago (2013-11-29 12:18:28 UTC) #5
dconnelly
On 2013/11/29 12:18:28, dconnelly wrote: > https://codereview.chromium.org/92153002/diff/20001/components/policy.gypi > File components/policy.gypi (right): > > https://codereview.chromium.org/92153002/diff/20001/components/policy.gypi#newcode76 > ...
7 years ago (2013-11-29 16:04:43 UTC) #6
jochen (gone - plz use gerrit)
lgtm
7 years ago (2013-12-02 10:36:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/92153002/140001
7 years ago (2013-12-02 14:32:43 UTC) #8
commit-bot: I haz the power
Change committed as 238097
7 years ago (2013-12-02 14:33:51 UTC) #9
dconnelly
A revert of this CL has been created in https://codereview.chromium.org/99333002/ by dconnelly@chromium.org. The reason for ...
7 years ago (2013-12-02 15:36:09 UTC) #10
jam
please don't use NOTRY=true for landing normal changes (i.e. not reverts)
7 years ago (2013-12-02 17:07:39 UTC) #11
dconnelly
7 years ago (2013-12-03 12:33:50 UTC) #12
Message was sent while issue was closed. 
On 2013/12/02 17:07:39, jam wrote:
> please don't use NOTRY=true for landing normal changes  (i.e. not reverts)

Okay. Sorry about that. To be clear, the try bots would not have caught the
compile failure as it's MSVC-specific, and I only ran the patch against the
compile try bots because there's no functional change.

Powered by Google App Engine
This is Rietveld 408576698