Move ConfigurationPolicyProvider, etc. to components/policy.

components/policy.gypi

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'policy_component',
       'type': '<(component)',
       'dependencies': [
         '../base/base.gyp:base',
         'json_schema',
         'component_strings.gyp:component_strings',
       ],
       'defines': [
         'POLICY_COMPONENT_IMPLEMENTATION',
       ],
       'include_dirs': [
         '..',
       ],
       'conditions': [
         ['configuration_policy==1', {
           'sources': [
             'policy/core/common/policy_bundle.cc',
             'policy/core/common/policy_bundle.h',

[Joao da Silva, 2013/11/28 07:59:36]

policy_bundle.* is out of order

[dconnelly, 2013/11/29 10:52:26]

Well, shit.

+            'policy/core/common/configuration_policy_provider.cc',
+            'policy/core/common/configuration_policy_provider.h',
             'policy/core/common/external_data_fetcher.cc',
             'policy/core/common/external_data_fetcher.h',
             'policy/core/common/external_data_manager.h',
             'policy/core/common/policy_details.h',
             'policy/core/common/policy_namespace.cc',
             'policy/core/common/policy_namespace.h',
             'policy/core/common/policy_map.cc',
             'policy/core/common/policy_map.h',
             'policy/core/common/policy_pref_names.cc',
             'policy/core/common/policy_pref_names.h',
@@ skipping 20 matching lines @@
             'policy/core/common/external_data_fetcher.cc',
             'policy/core/common/external_data_manager.h',
             'policy/core/common/policy_map.cc',
             'policy/core/common/policy_map.h',
             'policy/core/common/policy_namespace.cc',
             'policy/core/common/policy_namespace.h',
           ],
         }],
       ],
     },
+    {
+      'target_name': 'policy_test_support',

[Joao da Silva, 2013/11/28 07:59:36]

This target should exist only when configuration_policy==1. Add a "conditions'
entry to the toplevel object, and put this inside a configuration_policy==1
test.

[dconnelly, 2013/11/29 10:52:26]

Done.

+      'type': 'static_library',
+      'defines!': ['POLICY_COMPONENT_IMPLEMENTATION'],

[Joao da Silva, 2013/11/28 07:59:36]

Remove the "!". Also, for consistency with the target above and "include_dirs",
break the [ list ] into two or three lines.

[dconnelly, 2013/11/29 10:52:26]

Done.

+      'dependencies': [
+        'policy_component',
+        '../testing/gmock.gyp:gmock',
+        '../testing/gtest.gyp:gtest',
+      ],
+      'include_dirs': [
+        '..',
+      ],
+      'sources': [
+        'policy/core/common/configuration_policy_provider_test.cc',
+        'policy/core/common/configuration_policy_provider_test.h',
+        'policy/core/common/mock_configuration_policy_provider.cc',
+        'policy/core/common/mock_configuration_policy_provider.h',
+      ],
+    },
   ],
 }