Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.cc

Issue 921473006: GuestView: Fix message routing across embedder navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nit Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_embedder.cc
diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc
index 5313268a62405ca70663c29dd504a43baa501847..9aa73fae244d53d16dde11a919620386e8737497 100644
--- a/content/browser/browser_plugin/browser_plugin_embedder.cc
+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc
@@ -139,7 +139,8 @@ void BrowserPluginEmbedder::OnAttach(
const BrowserPluginHostMsg_Attach_Params& params) {
WebContents* guest_web_contents =
GetBrowserPluginGuestManager()->GetGuestByInstanceID(
- GetWebContents(), browser_plugin_instance_id);
+ GetWebContents()->GetRenderProcessHost()->GetID(),
Charlie Reis 2015/02/12 21:38:05 This won't work well with OOPIF, since a WebConten
Fady Samuel 2015/02/13 01:22:13 Done.
+ browser_plugin_instance_id);
if (!guest_web_contents)
return;
BrowserPluginGuest* guest = static_cast<WebContentsImpl*>(guest_web_contents)

Powered by Google App Engine
This is Rietveld 408576698