GuestView: Fix message routing across embedder navigations

content/browser/browser_plugin/browser_plugin_embedder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_embedder.h"
 
 #include "base/values.h"
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
@@ skipping 121 matching lines @@
 
 void BrowserPluginEmbedder::OnUpdateDragCursor(bool* handled) {
   *handled = (guest_dragging_over_.get() != NULL);
 }
 
 void BrowserPluginEmbedder::OnAttach(
     int browser_plugin_instance_id,
     const BrowserPluginHostMsg_Attach_Params& params) {
   WebContents* guest_web_contents =
       GetBrowserPluginGuestManager()->GetGuestByInstanceID(
-          GetWebContents(), browser_plugin_instance_id);
+          GetWebContents()->GetRenderProcessHost()->GetID(),

[Charlie Reis, 2015/02/12 21:38:05]

This won't work well with OOPIF, since a WebContents can have many
RenderProcessHosts.

Is there any way to know which RenderFrameHost this is coming from?  That's a
better place to get the process ID.

[Fady Samuel, 2015/02/13 01:22:13]

Done.

+          browser_plugin_instance_id);
   if (!guest_web_contents)
     return;
   BrowserPluginGuest* guest = static_cast<WebContentsImpl*>(guest_web_contents)
                                   ->GetBrowserPluginGuest();
   guest->Attach(browser_plugin_instance_id, GetWebContents(), params);
 }
 
 bool BrowserPluginEmbedder::HandleKeyboardEvent(
     const NativeWebKeyboardEvent& event) {
   if ((event.windowsKeyCode != ui::VKEY_ESCAPE) ||
@@ skipping 58 matching lines @@
   if (static_cast<WebContentsImpl*>(guest)->GetBrowserPluginGuest()
           ->StopFinding(action)) {
     // There can only ever currently be one browser plugin that handles find so
     // we can break the iteration at this point.
     return true;
   }
   return false;
 }
 
 }  // namespace content