content/public/browser/browser_plugin_guest_manager.h - Issue 921473006: GuestView: Fix message routing across embedder navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/browser_plugin_guest_manager.h

Issue 921473006: GuestView: Fix message routing across embedder navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated comments CQ'ing Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/browser/browser_plugin_guest_manager.h

diff --git a/content/public/browser/browser_plugin_guest_manager.h b/content/public/browser/browser_plugin_guest_manager.h

index 481a8ab6517ea603ad85997fb8798533ee022de6..0ab13c0188882c44844e982d271a4853a6a2a26c 100644

--- a/content/public/browser/browser_plugin_guest_manager.h

+++ b/content/public/browser/browser_plugin_guest_manager.h

@@ -19,9 +19,8 @@ class CONTENT_EXPORT BrowserPluginGuestManager {

virtual ~BrowserPluginGuestManager() {}

// Requests a guest WebContents associated with the provided

- // |browser_plugin_instance_id|.

- // Returns the guest associated with the provided ID if one exists.

- virtual WebContents* GetGuestByInstanceID(WebContents* embedder_web_contents,

+ // <owner_process_id, browser_plugin_instance_id> tuple.

+ virtual WebContents* GetGuestByInstanceID(int owner_process_id,

int browser_plugin_instance_id);

// Iterates over all WebContents belonging to a given |embedder_web_contents|,

« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/browser_plugin_guest_manager.cc » ('j') | no next file with comments »