Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 921473006: GuestView: Fix message routing across embedder navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated comments CQ'ing Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 8934d74ea4e47ca34520e5c98e9cab6241555739..3c46724086182f256112f0cb2c3841faf15eb3fa 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -566,7 +566,8 @@ bool WebContentsImpl::OnMessageReceived(RenderViewHost* render_view_host,
IPC_MESSAGE_HANDLER(ViewHostMsg_RequestPpapiBrokerPermission,
OnRequestPpapiBrokerPermission)
IPC_MESSAGE_HANDLER_GENERIC(BrowserPluginHostMsg_Attach,
- OnBrowserPluginMessage(message))
+ OnBrowserPluginMessage(render_frame_host,
+ message))
#endif
IPC_MESSAGE_HANDLER(ImageHostMsg_DidDownloadImage, OnDidDownloadImage)
IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateFaviconURL, OnUpdateFaviconURL)
@@ -1869,11 +1870,15 @@ void WebContentsImpl::AccessibilityEventReceived(
}
RenderFrameHost* WebContentsImpl::GetGuestByInstanceID(
+ RenderFrameHost* render_frame_host,
int browser_plugin_instance_id) {
BrowserPluginGuestManager* guest_manager =
GetBrowserContext()->GetGuestManager();
+ // TODO(fsamuel): Change message routing to use the process ID of the
+ // |render_frame_host| once BrowserPlugin IPCs get routed using the RFH
+ // routing ID. See http://crbug.com/436339.
WebContents* guest = guest_manager->GetGuestByInstanceID(
- this, browser_plugin_instance_id);
+ GetRenderProcessHost()->GetID(), browser_plugin_instance_id);
if (!guest)
return NULL;
return guest->GetMainFrame();
@@ -3115,7 +3120,8 @@ void WebContentsImpl::OnPpapiBrokerPermissionResult(int routing_id,
Send(new ViewMsg_PpapiBrokerPermissionResult(routing_id, result));
}
-void WebContentsImpl::OnBrowserPluginMessage(const IPC::Message& message) {
+void WebContentsImpl::OnBrowserPluginMessage(RenderFrameHost* render_frame_host,
+ const IPC::Message& message) {
// This creates a BrowserPluginEmbedder, which handles all the BrowserPlugin
// specific messages for this WebContents. This means that any message from
// a BrowserPlugin prior to this will be ignored.
@@ -3123,7 +3129,7 @@ void WebContentsImpl::OnBrowserPluginMessage(const IPC::Message& message) {
// BrowserPluginGuest.
CHECK(!browser_plugin_embedder_.get());
browser_plugin_embedder_.reset(BrowserPluginEmbedder::Create(this));
- browser_plugin_embedder_->OnMessageReceived(message);
+ browser_plugin_embedder_->OnMessageReceived(message, render_frame_host);
}
#endif // defined(ENABLE_PLUGINS)
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/public/browser/browser_plugin_guest_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698