Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: net/url_request/url_request.cc

Issue 921453003: Allow URLRequest::AppendChunkToUpload to take 0-byte final chunks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index af06e3503b32c5b4a25d196798e5b2528268728d..d75a19c44899bd46f691970f57002448fba8c702 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -210,7 +210,6 @@ void URLRequest::AppendChunkToUpload(const char* bytes,
bool is_last_chunk) {
DCHECK(upload_data_stream_);
DCHECK(upload_data_stream_->is_chunked());
mmenke 2015/02/11 19:43:56 And one quick note...ChunkedUploadDataStream alrea
- DCHECK_GT(bytes_len, 0);
upload_chunked_data_stream_->AppendData(bytes, bytes_len, is_last_chunk);
}
« net/http/http_stream_parser_unittest.cc ('K') | « net/http/http_stream_parser_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698