Allow URLRequest::AppendChunkToUpload to take 0-byte final chunks.

net/url_request/url_request.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
@@ skipping 191 matching lines @@
   if (!upload_data_stream_) {
     upload_chunked_data_stream_ = new ChunkedUploadDataStream(0);
     upload_data_stream_.reset(upload_chunked_data_stream_);
   }
 }
 
 void URLRequest::AppendChunkToUpload(const char* bytes,
                                      int bytes_len,
                                      bool is_last_chunk) {
   DCHECK(upload_data_stream_);
   DCHECK(upload_data_stream_->is_chunked());

[mmenke, 2015/02/11 19:43:56]

And one quick note...ChunkedUploadDataStream already has a bytes len can only be
0 for the final chunk DCHECK, so no reason to have it here.

-  DCHECK_GT(bytes_len, 0);
   upload_chunked_data_stream_->AppendData(bytes, bytes_len, is_last_chunk);
 }
 
 void URLRequest::set_upload(scoped_ptr<UploadDataStream> upload) {
   DCHECK(!upload->is_chunked());
   upload_data_stream_ = upload.Pass();
 }
 
 const UploadDataStream* URLRequest::get_upload() const {
   return upload_data_stream_.get();
@@ skipping 974 matching lines @@
       new base::debug::StackTrace(NULL, 0);
   *stack_trace_copy = stack_trace;
   stack_trace_.reset(stack_trace_copy);
 }
 
 const base::debug::StackTrace* URLRequest::stack_trace() const {
   return stack_trace_.get();
 }
 
 }  // namespace net