Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 92143003: Docserver: Reorganise the site templates into a single site.html file which (Closed)

Created:
7 years ago by not at google - send to devlin
Modified:
7 years ago
Reviewers:
mkearney1, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Docserver: Reorganise the site templates into a single site.html file which defines the entire site chrome, rather than spreading it over several files. BUG=320339 R=mkearney@chromium.org, yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238221

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -361 lines) Patch
M chrome/common/extensions/docs/server2/api_data_source.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/content_provider.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron_servlet_test.py View 1 6 chunks +16 lines, -13 lines 0 comments Download
M chrome/common/extensions/docs/server2/intro_data_source.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/manifest_data_source.py View 1 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/manifest_data_source_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/render_servlet.py View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/strings_data_source.py View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/table_of_contents_renderer.py View 2 chunks +6 lines, -2 lines 0 comments Download
D chrome/common/extensions/docs/static/css/index.css View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/common/extensions/docs/static/css/samples.css View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/common/extensions/docs/static/css/site.css View 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/manifest.json View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/json/strings.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/common/extensions/docs/templates/private/api.html View 1 1 chunk +24 lines, -0 lines 0 comments Download
D chrome/common/extensions/docs/templates/private/api_namespace.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/private/api_property.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/private/api_reference.html View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/docs/templates/private/api_title.html View 1 chunk +0 lines, -2 lines 0 comments Download
A chrome/common/extensions/docs/templates/private/article.html View 1 chunk +13 lines, -0 lines 0 comments Download
D chrome/common/extensions/docs/templates/private/footer.html View 1 chunk +0 lines, -49 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/function_signature.html View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/docs/templates/private/header_body.html View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/common/extensions/docs/templates/private/header_head.html View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/samples.html View 1 chunk +37 lines, -44 lines 0 comments Download
D chrome/common/extensions/docs/templates/private/sidenav.html View 1 chunk +0 lines, -3 lines 0 comments Download
A chrome/common/extensions/docs/templates/private/site.html View 1 chunk +124 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/standard_apps_api.html View 1 chunk +7 lines, -33 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/standard_apps_article.html View 1 chunk +5 lines, -19 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/standard_extensions_api.html View 1 chunk +7 lines, -33 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/standard_extensions_article.html View 1 chunk +5 lines, -19 lines 0 comments Download
D chrome/common/extensions/docs/templates/private/title.html View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/samples.html View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/extensions/samples.html View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
Ok here we go finally. A big template change (mostly deleting redundant stuff) and some ...
7 years ago (2013-11-27 19:37:57 UTC) #1
mkearney1
I'm trying to test this patch and am getting the following error (note that I'm ...
7 years ago (2013-12-02 18:00:21 UTC) #2
mkearney1
lgtm so long as GitHub user-agent fixes go in.
7 years ago (2013-12-02 22:24:37 UTC) #3
not at google - send to devlin
Committed patchset #3 manually as r238221 (presubmit successful).
7 years ago (2013-12-02 23:10:46 UTC) #4
Yoyo Zhou
7 years ago (2013-12-02 23:33:58 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698