chrome/common/extensions/docs/server2/strings_data_source.py - Issue 92143003: Docserver: Reorganise the site templates into a single site.html file which

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/strings_data_source.py

Issue 92143003: Docserver: Reorganise the site templates into a single site.html file which (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/render_servlet.py ('k') | chrome/common/extensions/docs/server2/table_of_contents_renderer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/strings_data_source.py

diff --git a/chrome/common/extensions/docs/server2/strings_data_source.py b/chrome/common/extensions/docs/server2/strings_data_source.py

index 11d68991dbea23fff4129cbdad5b21591b607977..5dca1af224d3198f8f5b97951a87d82c150a912d 100644

--- a/chrome/common/extensions/docs/server2/strings_data_source.py

+++ b/chrome/common/extensions/docs/server2/strings_data_source.py

@@ -2,6 +2,8 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

+import logging

from extensions_paths import JSON_TEMPLATES

from data_source import DataSource

@@ -21,4 +23,7 @@ class StringsDataSource(DataSource):

return self._GetStringsData()

def get(self, key):

- return self._GetStringsData().Get().get(key)

+ string = self._GetStringsData().Get().get(key)

+ if string is None:

+ logging.warning('String "%s" not found' % key)

+ return string