Rename ExtensionWarningBadgeService to WarningBadgeService

Rename ExtensionWarningBadgeService to WarningBadgeService

As the comment in extension_warning_badge_service.h by battre@,
rename ExtensionWarningBadgeService to WarningBadgeService and related class.
And rename the files too.

BUG=458829
R=rockot@chromium.org

Committed: https://crrev.com/6fcce6acc4e79e19f0910d1b3e9eb2e3327e0856
Cr-Commit-Position: refs/heads/master@{#317992}

[Ken Rockot(use gerrit already), 2015-02-17 19:13:29]

rockot@chromium.org changed reviewers:
+ battre@chromium.org

[Ken Rockot(use gerrit already), 2015-02-17 19:13:29]

looks ok but also +battre since he wrote the TODO

https://codereview.chromium.org/921423003/diff/1/chrome/browser/extensions/wa...
File chrome/browser/extensions/warning_badge_service.h (right):

https://codereview.chromium.org/921423003/diff/1/chrome/browser/extensions/wa...
chrome/browser/extensions/warning_badge_service.h:21: public
WarningService::Observer,
Please align the base class specifiers.

You can run 'git cl format' from your repo to automatically apply standard
formatting and catch things like this for you.

[battre, 2015-02-19 14:26:38]

On 2015/02/17 at 19:13:29, rockot wrote:
> looks ok but also +battre since he wrote the TODO
> 
>
https://codereview.chromium.org/921423003/diff/1/chrome/browser/extensions/wa...
> File chrome/browser/extensions/warning_badge_service.h (right):
> 
>
https://codereview.chromium.org/921423003/diff/1/chrome/browser/extensions/wa...
> chrome/browser/extensions/warning_badge_service.h:21: public
WarningService::Observer,
> Please align the base class specifiers.
> 
> You can run 'git cl format' from your repo to automatically apply standard
formatting and catch things like this for you.

+1 to running git cl format. There are several locations that need to be updated
for formatting.

Thanks for taking care of this!

[zhuoyu.qian, 2015-02-25 01:01:48]

I have update the format as your comment, please have a review. Thank you.

[Ken Rockot(use gerrit already), 2015-02-25 01:44:39]

Thanks! lgtm

[zhuoyu.qian, 2015-02-25 03:58:36]

zhuoyu.qian@samsung.com changed reviewers:
+ thakis@chromium.org

[zhuoyu.qian, 2015-02-25 03:58:37]

Hi Nico:
I'd like you to do a code review for
chrome/chrome_browser_extensions.gypi
chrome/chrome_tests_unit.gypi
Thank you.

[Nico, 2015-02-25 04:51:06]

lgtm

[zhuoyu.qian, 2015-02-25 05:17:32]

The CQ bit was checked by zhuoyu.qian@samsung.com

[zhuoyu.qian, 2015-02-25 05:17:33]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/921423003/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2015-02-25 05:18:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/921423003/40001

[commit-bot: I haz the power, 2015-02-25 06:02:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-25 06:03:05]

Patchset 3 (id:??) landed as
https://crrev.com/6fcce6acc4e79e19f0910d1b3e9eb2e3327e0856
Cr-Commit-Position: refs/heads/master@{#317992}