Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 921423003: Rename ExtensionWarningBadgeService to WarningBadgeService (Closed)

Created:
5 years, 10 months ago by zhuoyu.qian
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ExtensionWarningBadgeService to WarningBadgeService As the comment in extension_warning_badge_service.h by battre@, rename ExtensionWarningBadgeService to WarningBadgeService and related class. And rename the files too. BUG=458829 R=rockot@chromium.org Committed: https://crrev.com/6fcce6acc4e79e19f0910d1b3e9eb2e3327e0856 Cr-Commit-Position: refs/heads/master@{#317992}

Patch Set 1 #

Total comments: 1

Patch Set 2 : update format #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -475 lines) Patch
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 3 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/extensions/extension_warning_badge_service.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/extensions/extension_warning_badge_service.cc View 1 chunk +0 lines, -152 lines 0 comments Download
D chrome/browser/extensions/extension_warning_badge_service_factory.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/extensions/extension_warning_badge_service_factory.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/extensions/extension_warning_badge_service_unittest.cc View 1 chunk +0 lines, -94 lines 0 comments Download
A + chrome/browser/extensions/warning_badge_service.h View 1 2 chunks +7 lines, -9 lines 0 comments Download
A + chrome/browser/extensions/warning_badge_service.cc View 1 7 chunks +28 lines, -19 lines 0 comments Download
A + chrome/browser/extensions/warning_badge_service_factory.h View 1 2 chunks +8 lines, -9 lines 0 comments Download
A + chrome/browser/extensions/warning_badge_service_factory.cc View 1 2 chunks +13 lines, -16 lines 0 comments Download
A + chrome/browser/extensions/warning_badge_service_unittest.cc View 1 6 chunks +11 lines, -13 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
zhuoyu.qian
5 years, 10 months ago (2015-02-15 09:18:38 UTC) #1
Ken Rockot(use gerrit already)
looks ok but also +battre since he wrote the TODO https://codereview.chromium.org/921423003/diff/1/chrome/browser/extensions/warning_badge_service.h File chrome/browser/extensions/warning_badge_service.h (right): https://codereview.chromium.org/921423003/diff/1/chrome/browser/extensions/warning_badge_service.h#newcode21 ...
5 years, 10 months ago (2015-02-17 19:13:29 UTC) #3
battre
On 2015/02/17 at 19:13:29, rockot wrote: > looks ok but also +battre since he wrote ...
5 years, 10 months ago (2015-02-19 14:26:38 UTC) #4
zhuoyu.qian
I have update the format as your comment, please have a review. Thank you.
5 years, 10 months ago (2015-02-25 01:01:48 UTC) #5
Ken Rockot(use gerrit already)
Thanks! lgtm
5 years, 10 months ago (2015-02-25 01:44:39 UTC) #6
zhuoyu.qian
Hi Nico: I'd like you to do a code review for chrome/chrome_browser_extensions.gypi chrome/chrome_tests_unit.gypi Thank you.
5 years, 10 months ago (2015-02-25 03:58:37 UTC) #8
Nico
lgtm
5 years, 10 months ago (2015-02-25 04:51:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921423003/40001
5 years, 10 months ago (2015-02-25 05:18:17 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-25 06:02:20 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 06:03:05 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6fcce6acc4e79e19f0910d1b3e9eb2e3327e0856
Cr-Commit-Position: refs/heads/master@{#317992}

Powered by Google App Engine
This is Rietveld 408576698