chrome/browser/extensions/extension_warning_badge_service_unittest.cc - Issue 921423003: Rename ExtensionWarningBadgeService to WarningBadgeService

Side by Side Diff: chrome/browser/extensions/extension_warning_badge_service_unittest.cc

Issue 921423003: Rename ExtensionWarningBadgeService to WarningBadgeService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 #include "chrome/browser/extensions/extension_warning_badge_service.h"

6

7 #include "chrome/app/chrome_command_ids.h"

8 #include "chrome/browser/profiles/profile.h"

9 #include "chrome/browser/ui/global_error/global_error_service.h"

10 #include "chrome/browser/ui/global_error/global_error_service_factory.h"

11 #include "chrome/test/base/testing_profile.h"

12 #include "extensions/browser/warning_service.h"

13 #include "extensions/browser/warning_set.h"

14 #include "testing/gtest/include/gtest/gtest.h"

15

16 namespace extensions {

17

18 namespace {

19

20 class TestExtensionWarningSet : public WarningService {

21 public:

22 explicit TestExtensionWarningSet(Profile* profile) : WarningService(profile) {

23 }

24 ~TestExtensionWarningSet() override {}

25

26 void AddWarning(const Warning& warning) {

27 WarningSet warnings;

28 warnings.insert(warning);

29 AddWarnings(warnings);

30 }

31 };

32

33 class TestExtensionWarningBadgeService : public ExtensionWarningBadgeService {

34 public:

35 TestExtensionWarningBadgeService(Profile* profile,

36 WarningService* warning_service)

37 : ExtensionWarningBadgeService(profile),

38 warning_service_(warning_service) {}

39 ~TestExtensionWarningBadgeService() override {}

40

41 const std::set<Warning>& GetCurrentWarnings() const override {

42 return warning_service_->warnings();

43 }

44

45 private:

46 WarningService* warning_service_;

47 };

48

49 bool HasBadge(Profile* profile) {

50 GlobalErrorService* service =

51 GlobalErrorServiceFactory::GetForProfile(profile);

52 return service->GetGlobalErrorByMenuItemCommandID(IDC_EXTENSION_ERRORS) !=

53 NULL;

54 }

55

56 const char ext1_id[] = "extension1";

57 const char ext2_id[] = "extension2";

58

59 } // namespace

60

61 // Check that no badge appears if it has been suppressed for a specific

62 // warning.

63 TEST(ExtensionWarningBadgeServiceTest, SuppressBadgeForCurrentWarnings) {

64 TestingProfile profile;

65 TestExtensionWarningSet warnings(&profile);

66 TestExtensionWarningBadgeService badge_service(&profile, &warnings);

67 warnings.AddObserver(&badge_service);

68

69 // Insert first warning.

70 warnings.AddWarning(Warning::CreateNetworkDelayWarning(ext1_id));

71 EXPECT_TRUE(HasBadge(&profile));

72

73 // Suppress first warning.

74 badge_service.SuppressCurrentWarnings();

75 EXPECT_FALSE(HasBadge(&profile));

76

77 // Simulate deinstallation of extension.

78 std::set<Warning::WarningType> to_clear =

79 warnings.GetWarningTypesAffectingExtension(ext1_id);

80 warnings.ClearWarnings(to_clear);

81 EXPECT_FALSE(HasBadge(&profile));

82

83 // Set first warning again and verify that not badge is shown this time.

84 warnings.AddWarning(Warning::CreateNetworkDelayWarning(ext1_id));

85 EXPECT_FALSE(HasBadge(&profile));

86

87 // Set second warning and verify that it shows a badge.

88 warnings.AddWarning(Warning::CreateNetworkConflictWarning(ext2_id));

89 EXPECT_TRUE(HasBadge(&profile));

90

91 warnings.RemoveObserver(&badge_service);

92 }

93

94 } // namespace extensions

OLD	NEW