Make GrResourceCache use a priority queue of purgeable resources.

Make GrResourceCache use a priority queue of purgeable resources.

Committed: https://skia.googlesource.com/skia/+/9f2d1571ed1f0ed579e5d7779c46a90e20f30f22

[bsalomon, 2015-02-17 14:29:20]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2015-02-17 17:55:46]

lgtm + mainly dox requests

https://codereview.chromium.org/921323002/diff/20001/include/gpu/GrGpuResource.h
File include/gpu/GrGpuResource.h (right):

https://codereview.chromium.org/921323002/diff/20001/include/gpu/GrGpuResourc...
include/gpu/GrGpuResource.h:289: 
Maybe more detail in the comment?
fCacheArrayIndex is the index of this resource in the purgeable priority queue.
It is zero when not in the queue.
fTimestamp ...

?

https://codereview.chromium.org/921323002/diff/20001/src/gpu/GrResourceCache.cpp
File src/gpu/GrResourceCache.cpp (right):

https://codereview.chromium.org/921323002/diff/20001/src/gpu/GrResourceCache....
src/gpu/GrResourceCache.cpp:270: bool underBudget = fBudgetedCount < fMaxCount
&&
line this up ?

https://codereview.chromium.org/921323002/diff/20001/src/gpu/GrResourceCache....
src/gpu/GrResourceCache.cpp:364: void GrResourceCache::purgeAllUnlocked() {
Can we turn off the heap property during this ?

https://codereview.chromium.org/921323002/diff/20001/src/gpu/GrResourceCache.h
File src/gpu/GrResourceCache.h (right):

https://codereview.chromium.org/921323002/diff/20001/src/gpu/GrResourceCache....
src/gpu/GrResourceCache.h:230: 
// This fTimestamp is the central source for monotonically increasing resource
time stamps. As such it is used to priority sort those resources in the cache
and the keep an appropriate order when a resource becomes newly purgeable.
?

[bsalomon, 2015-02-17 19:17:44]

New patchsets have been uploaded after l-g-t-m from robertphillips@google.com

[bsalomon, 2015-02-17 19:18:43]

https://codereview.chromium.org/921323002/diff/20001/include/gpu/GrGpuResource.h
File include/gpu/GrGpuResource.h (right):

https://codereview.chromium.org/921323002/diff/20001/include/gpu/GrGpuResourc...
include/gpu/GrGpuResource.h:289: 
On 2015/02/17 17:55:46, robertphillips wrote:
> Maybe more detail in the comment?
> fCacheArrayIndex is the index of this resource in the purgeable priority
queue.
> It is zero when not in the queue.
> fTimestamp ...
> 
> ?

Done.

https://codereview.chromium.org/921323002/diff/20001/src/gpu/GrResourceCache.cpp
File src/gpu/GrResourceCache.cpp (right):

https://codereview.chromium.org/921323002/diff/20001/src/gpu/GrResourceCache....
src/gpu/GrResourceCache.cpp:270: bool underBudget = fBudgetedCount < fMaxCount
&&
On 2015/02/17 17:55:46, robertphillips wrote:
> line this up ?

Done.

https://codereview.chromium.org/921323002/diff/20001/src/gpu/GrResourceCache....
src/gpu/GrResourceCache.cpp:364: void GrResourceCache::purgeAllUnlocked() {
On 2015/02/17 17:55:46, robertphillips wrote:
> Can we turn off the heap property during this ?

Theretically we could but it would add significant complexity. The heap is
updated not here but when removeResource() is called. We'd still have to handle
a purge of one resource triggering the purgeability of another. And this is
pretty low frequency. I'll add a comment.

https://codereview.chromium.org/921323002/diff/20001/src/gpu/GrResourceCache.h
File src/gpu/GrResourceCache.h (right):

https://codereview.chromium.org/921323002/diff/20001/src/gpu/GrResourceCache....
src/gpu/GrResourceCache.h:230: 
On 2015/02/17 17:55:46, robertphillips wrote:
> // This fTimestamp is the central source for monotonically increasing resource
> time stamps. As such it is used to priority sort those resources in the cache
> and the keep an appropriate order when a resource becomes newly purgeable.
> ? 

Done.

[bsalomon, 2015-02-17 19:18:49]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-02-17 19:19:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/921323002/40001

[commit-bot: I haz the power, 2015-02-17 19:47:45]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/9f2d1571ed1f0ed579e5d7779c46a90e20f30f22