Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: mojo/public/js/validation_unittests.js

Issue 921223002: Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Fixes spelling error. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/js/validation_unittests.js
diff --git a/mojo/public/js/validation_unittests.js b/mojo/public/js/validation_unittests.js
index a04879cd4b00f3bda1d466b88837bcdcae35371d..a235bd8c9db8b42a26ad567c6b24d9f4df9f946d 100644
--- a/mojo/public/js/validation_unittests.js
+++ b/mojo/public/js/validation_unittests.js
@@ -225,11 +225,13 @@ define([
expect(testFiles.length).toBeGreaterThan(0);
for (var i = 0; i < testFiles.length; i++) {
- // TODO(hansmuller, yzshen): Temporarily skipping:
+ // TODO(hansmuller, yzshen, rudominer): Temporarily skipping:
// - array pointer overflow tests;
// - struct versioning tests (tests with "mthd11" in the name).
+ // - no-such-method validation check tests.
if (testFiles[i].indexOf("overflow") != -1 ||
- testFiles[i].indexOf("mthd11") != -1) {
+ testFiles[i].indexOf("mthd11") != -1 ||
+ testFiles[i].indexOf("no_such_method") != -1) {
console.log("[Skipping " + testFiles[i] + "]");
continue;
}
@@ -258,7 +260,9 @@ define([
for (var i = 0; i < testFiles.length; i++) {
// TODO(hansmuller): Temporarily skipping array pointer overflow tests.
yzshen1 2015/03/03 18:05:37 This whole if-statement can be removed, because we
rudominer 2015/03/04 00:12:01 Done.
- if (testFiles[i].indexOf("overflow") != -1) {
+ // TODO(rudominer) Temporarily skipping no-such-method verifcation tests.
+ if (testFiles[i].indexOf("overflow") != -1 ||
+ testFiles[i].indexOf("no_such_method") != -1) {
console.log("[Skipping " + testFiles[i] + "]");
continue;
}

Powered by Google App Engine
This is Rietveld 408576698