mojo/public/interfaces/bindings/tests/data/validation/conformance_no_such_method.data - Issue 921223002: Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/bindings/tests/data/validation/conformance_no_such_method.data

Issue 921223002: Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fixes spelling error. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/lib/validation_errors.cc ('K') | « mojo/public/cpp/bindings/lib/validation_errors.cc ('k') | mojo/public/interfaces/bindings/tests/data/validation/conformance_no_such_method.expected » ('j') | mojo/public/js/validation_unittests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/interfaces/bindings/tests/data/validation/conformance_no_such_method.data

diff --git a/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd0_incomplete_struct_header.data b/mojo/public/interfaces/bindings/tests/data/validation/conformance_no_such_method.data

similarity index 50%

copy from mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd0_incomplete_struct_header.data

copy to mojo/public/interfaces/bindings/tests/data/validation/conformance_no_such_method.data

index 9a362f6156e4da0e929c45199542ce72f1618b34..47d7924df10e9baeb577eb5f182a343e9e6add1a 100644

--- a/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd0_incomplete_struct_header.data

+++ b/mojo/public/interfaces/bindings/tests/data/validation/conformance_no_such_method.data

@@ -1,7 +1,5 @@

[dist4]message_header // num_bytes

yzshen1 2015/03/03 18:05:37 The name of the test should probably have "msghdr_

rudominer 2015/03/04 00:12:01 Done.

[u4]2 // num_fields

-[u4]0 // name

+[u4]9999 // There is no Method9999

yzshen1 2015/03/03 18:05:37 Period at the end of a sentence, please.

rudominer 2015/03/04 00:12:01 Done.

[u4]0 // flags

-[anchr]message_header

-[u4]16 // num_bytes: Incomplete struct header.

+[anchr]message_header