mojo/public/cpp/bindings/lib/validation_errors.cc - Issue 921223002: Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/validation_errors.cc

Issue 921223002: Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fixes spelling error. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/lib/validation_errors.h ('k') | mojo/public/interfaces/bindings/tests/data/validation/conformance_no_such_method.data » ('j') | mojo/public/interfaces/bindings/tests/data/validation/conformance_no_such_method.data » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/lib/validation_errors.cc

diff --git a/mojo/public/cpp/bindings/lib/validation_errors.cc b/mojo/public/cpp/bindings/lib/validation_errors.cc

index d1d723a15529dfe464965454de6a1b53ede304fe..1a9ac6f725b8940be0d031f642d38dd3734c3f47 100644

--- a/mojo/public/cpp/bindings/lib/validation_errors.cc

+++ b/mojo/public/cpp/bindings/lib/validation_errors.cc

@@ -40,6 +40,8 @@ const char* ValidationErrorToString(ValidationError error) {

return "VALIDATION_ERROR_MESSAGE_HEADER_INVALID_FLAG_COMBINATION";

case VALIDATION_ERROR_MESSAGE_HEADER_MISSING_REQUEST_ID:

return "VALIDATION_ERROR_MESSAGE_HEADER_MISSING_REQUEST_ID";

+ case VALIDATION_ERROR_MESSAGE_HEADER_UNKNOWN_METHOD:

yzshen1 2015/03/03 18:05:37 Please use the exact same order as the enum defini

rudominer 2015/03/04 00:12:01 Done.

+ return "VALIDATION_ERROR_MESSAGE_HEADER_UNKNOWN_METHOD";

case VALIDATION_ERROR_DIFFERENT_SIZED_ARRAYS_IN_MAP:

return "VALIDATION_ERROR_DIFFERENT_SIZED_ARRAYS_IN_MAP";

case VALIDATION_ERROR_UNKOWN_UNION_TAG: