mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_nosuch.data - Issue 921223002: Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_nosuch.data

Issue 921223002: Cpp bindings: Return false from Validator::Accept() on unrecognized message or invalid flags (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fix test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« mojo/public/cpp/bindings/lib/validation_errors.h ('K') | « mojo/public/cpp/bindings/lib/validation_errors.cc ('k') | mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd11_nosuch.expected » ('j') | mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [dist4]message_header // num_bytes	1 [dist4]message_header // num_bytes

2 [u4]2 // num_fields	2 [u4]2 // num_fields

3 [u4]0 // name	3 [u4]11 // There is no Method11
	yzshen1 2015/02/23 19:08:02 Please use a huge number. Because we will add mor Please use a huge number. Because we will add more methods to this interface for sure (for example, in a pending CL I am going to add Methd11 https://codereview.chromium.org/951573002/), by using a huge number we don't need to update this test frequently. rudominer 2015/03/03 01:54:35 Done. Show quoted text On 2015/02/23 19:08:02, yzshen1 wrote: > Please use a huge number. > > Because we will add more methods to this interface for sure (for example, in a > pending CL I am going to add Methd11 > https://codereview.chromium.org/951573002/), by using a huge number we don't > need to update this test frequently. > Done.
4 [u4]0 // flags	4 [u4]0 // flags

5 [anchr]message_header	5 [anchr]message_header

6

7 [u4]16 // num_bytes: Incomplete struct header.

OLD	NEW