Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: content/browser/message_port_service.h

Issue 921013002: Optionally have MessagePort pass data as base::Value, part 1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-c-move-v8-value-converter
Patch Set: Update singly-included comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/message_port_provider_browsertest.cc ('k') | content/browser/message_port_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/message_port_service.h
diff --git a/content/browser/message_port_service.h b/content/browser/message_port_service.h
index 5623e94cf07138084b286658c4ef8e0f2e4a5230..1e561b2acab729a4f3bc8067510dba36ccecf0f3 100644
--- a/content/browser/message_port_service.h
+++ b/content/browser/message_port_service.h
@@ -13,6 +13,7 @@
#include "base/memory/singleton.h"
#include "base/strings/string16.h"
#include "content/common/content_export.h"
+#include "content/public/common/message_port_types.h"
#include "ipc/ipc_message.h"
namespace content {
@@ -20,7 +21,7 @@ class MessagePortDelegate;
class CONTENT_EXPORT MessagePortService {
public:
- typedef std::vector<std::pair<base::string16, std::vector<int> > >
+ typedef std::vector<std::pair<content::MessagePortMessage, std::vector<int>>>
QueuedMessages;
// Returns the MessagePortService singleton.
@@ -33,7 +34,7 @@ class CONTENT_EXPORT MessagePortService {
void Destroy(int message_port_id);
void Entangle(int local_message_port_id, int remote_message_port_id);
void PostMessage(int sender_message_port_id,
- const base::string16& message,
+ const MessagePortMessage& message,
const std::vector<int>& sent_message_port_ids);
void QueueMessages(int message_port_id);
void SendQueuedMessages(int message_port_id,
@@ -72,7 +73,7 @@ class CONTENT_EXPORT MessagePortService {
~MessagePortService();
void PostMessageTo(int message_port_id,
- const base::string16& message,
+ const MessagePortMessage& message,
const std::vector<int>& sent_message_port_ids);
// Handles the details of removing a message port id. Before calling this,
« no previous file with comments | « content/browser/message_port_provider_browsertest.cc ('k') | content/browser/message_port_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698