content/browser/message_port_service.cc - Issue 921013002: Optionally have MessagePort pass data as base::Value, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/message_port_service.cc

Issue 921013002: Optionally have MessagePort pass data as base::Value, part 1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-c-move-v8-value-converter

Patch Set: Update singly-included comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/message_port_service.h ('k') | content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/message_port_service.cc

diff --git a/content/browser/message_port_service.cc b/content/browser/message_port_service.cc

index 9ee4d70c24490c578e3335454adb471f5249dde7..597b1906f0762d519bfefce7d67f23d9b9b12351 100644

--- a/content/browser/message_port_service.cc

+++ b/content/browser/message_port_service.cc

@@ -133,7 +133,7 @@ void MessagePortService::Entangle(int local_message_port_id,

void MessagePortService::PostMessage(

int sender_message_port_id,

- const base::string16& message,

+ const MessagePortMessage& message,

const std::vector<int>& sent_message_port_ids) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

if (!message_ports_.count(sender_message_port_id)) {

@@ -156,7 +156,7 @@ void MessagePortService::PostMessage(

void MessagePortService::PostMessageTo(

int message_port_id,

- const base::string16& message,

+ const MessagePortMessage& message,

const std::vector<int>& sent_message_port_ids) {

if (!message_ports_.count(message_port_id)) {

NOTREACHED();