Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 920963002: [tracing] Add a DCHECK to ensure that trace events have a valid timestamp. (Closed)

Created:
5 years, 10 months ago by rmcilroy
Modified:
5 years, 10 months ago
Reviewers:
nduca
CC:
chromium-reviews, wfh+watch_chromium.org, dsinclair+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Add a DCHECK to ensure that trace events have a valid timestamp. Non metadata trace events should not have zero timestamps, so add a DCHECK that this is the case. BUG=456940, 456940 Committed: https://crrev.com/1731b978931677a486acae529b0e88d21ad3784f Cr-Commit-Position: refs/heads/master@{#316226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/trace_event/trace_event_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
nduca
lgtm
5 years, 10 months ago (2015-02-12 21:27:34 UTC) #2
rmcilroy
Nat: could you please take a look. Please see the discussion on crbug.com/456940 for the ...
5 years, 10 months ago (2015-02-12 21:28:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920963002/1
5 years, 10 months ago (2015-02-12 21:31:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/32071)
5 years, 10 months ago (2015-02-12 23:16:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920963002/1
5 years, 10 months ago (2015-02-13 15:35:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 16:32:44 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 16:33:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1731b978931677a486acae529b0e88d21ad3784f
Cr-Commit-Position: refs/heads/master@{#316226}

Powered by Google App Engine
This is Rietveld 408576698