base/trace_event/trace_event_impl.cc - Issue 920963002: [tracing] Add a DCHECK to ensure that trace events have a valid timestamp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_impl.cc

Issue 920963002: [tracing] Add a DCHECK to ensure that trace events have a valid timestamp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/trace_event_impl.cc

diff --git a/base/trace_event/trace_event_impl.cc b/base/trace_event/trace_event_impl.cc

index 763ff464b41ac410ef27e2997add4b850c370aa5..e319cba2f5171ee14dfcae7d7b6a81bd938b8b7f 100644

--- a/base/trace_event/trace_event_impl.cc

+++ b/base/trace_event/trace_event_impl.cc

@@ -1921,6 +1921,7 @@ TraceEventHandle TraceLog::AddTraceEventWithThreadIdAndTimestamp(

AutoThreadLocalBoolean thread_is_in_trace_event(&thread_is_in_trace_event_);

DCHECK(name);

+ DCHECK(!timestamp.is_null());

if (flags & TRACE_EVENT_FLAG_MANGLE_ID)

id ^= process_id_hash_;

« no previous file with comments | « no previous file | no next file » | no next file with comments »